Patch Set 3:

(1 comment)

Previously the constant was truncated to u8 in `ec/quanta/it8518/ec.c:ec_read()`. That's replaced with `ec/acpi/ec.c:ec_read()`, and a compiler warning causes the stout build to fail (e.g. previous failed Jenkins build).

I don't know why it was 0x0138 before (maybe a typo + automatic formatting?), but 0x38 is the correct ECRAM address.

View Change

To view, visit change 31382. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7bea7445f34817cef1602843bbded59230bb8d47
Gerrit-Change-Number: 31382
Gerrit-PatchSet: 3
Gerrit-Owner: James <jye836@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: James <jye836@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sat, 23 Nov 2019 00:09:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment