Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48073 )
Change subject: soc/mediatek/mt8192: add dramc power control ......................................................................
Patch Set 13:
(5 comments)
https://review.coreboot.org/c/coreboot/+/48073/13//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48073/13//COMMIT_MSG@9 PS13, Line 9: Controls HV or LV of VDD1/VDD2/VDDQ/VMDDR. Please elaborate.
https://review.coreboot.org/c/coreboot/+/48073/13/src/soc/mediatek/mt8192/dr... File src/soc/mediatek/mt8192/dramc_power.c:
https://review.coreboot.org/c/coreboot/+/48073/13/src/soc/mediatek/mt8192/dr... PS13, Line 19: #ifdef HQA_HV : return cali->vcore_voltage / 100 * 105; : #elif defined(HQA_LV) : return cali->vcore_voltage / 100 * 95; : #else : return cali->vcore_voltage; : #endif Please do this in C and not the preprocessor.
https://review.coreboot.org/c/coreboot/+/48073/13/src/soc/mediatek/mt8192/dr... PS13, Line 52: [%s]Set Please add a space after ]. (Also below.)
https://review.coreboot.org/c/coreboot/+/48073/13/src/soc/mediatek/mt8192/dr... PS13, Line 139: Please remove blank lines at the end of files.
https://review.coreboot.org/c/coreboot/+/48073/13/src/soc/mediatek/mt8192/in... File src/soc/mediatek/mt8192/include/soc/dramc_power.h:
https://review.coreboot.org/c/coreboot/+/48073/13/src/soc/mediatek/mt8192/in... PS13, Line 58: Ditto.