[coreboot-gerrit] [M] Change in coreboot[main]: security/tpm: Retrieve factory configuration for device w/ Google TPM

[Subrata Banik (Code Review)]

Attention is currently required from: Christian Walter, Nick Vaccaro, Paul Menzel, Paz Zcharya, Shelley Chen, Tim Van Patten.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79736?usp=email )

Change subject: security/tpm: Retrieve factory configuration for device w/ Google TPM
......................................................................

Patch Set 4:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/79736/comment/746c3cde_db4d5fdb :
PS4, Line 9: factory configuration data
> This is currently encoded in 8 bits?

The factory config space is a 64-bit, one-time programmable.
For the unprovisioned one, the read will be 0x0.

File src/security/tpm/tss/vendor/cr50/cr50.c:

https://review.coreboot.org/c/coreboot/+/79736/comment/cc26deaa_fa6f433b :
PS4, Line 186: 	printk(BIOS_INFO, "Reading factory config\n");
> Should the result be printed at the end?

i don't feel that is necessary (similar to other API like tlcl_cr50_get_boot_mode) example: https://review.coreboot.org/c/coreboot/+/79736/4/src/security/tpm/tss/vendor...