Please see my recent messages at CB:31448 . In short, this patch above, in its' current revision: is not fixing the things but is not breaking them either ( more details at this message - https://review.coreboot.org/c/coreboot/+/31448#message-8f77411787cf2f98295a72692a4deff2688859d7 ) so I am not voting on it yet but will be following.

View Change

To view, visit change 31502. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id2212f29f0de051f6cbd59f8332e86696c1166ab
Gerrit-Change-Number: 31502
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: mikeb mikeb <mikebdp2@gmail.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 18:04:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment