Attention is currently required from: Felix Singer, Michał Żygowski, Angel Pons, Michael Niewöhner.
31 comments:
Patchset:
Rebased on master, where the correct `clevo/tgl-u` structure is already present.
File src/mainboard/clevo/tgl-u/Kconfig:
Patch Set #3, Line 14: select NO_UART_ON_SUPERIO
Shouldn't be needed, selecting `INTEL_LPSS_UART_FOR_CONSOLE` should already provide the necessary im […]
File removed
Patch Set #3, Line 20: select HAVE_SMI_HANDLER
SoC already selects this
File removed
Patch Set #3, Line 22: select TPM_MEASURED_BOOT
Why is it necessary to force people to use measured boot? This option is user-configurable, selectin […]
File removed
Patch Set #3, Line 25: bool "NV4x"
Why does this have a prompt? You can simply omit the line, the type only needs to be specified once […]
Prompt removed
Patch Set #3, Line 32: string
Type not needed
Removed
Patch Set #3, Line 36: string
Type not needed
Removed
Patch Set #3, Line 40: string
Type not needed
Option removed
config MAX_CPUS
int
default 8
Is this actually needed?
Removed
config PCIEXP_HOTPLUG
default y
Redundant, given the select statement at the start of the file.
Removed
config PCIEXP_HOTPLUG_BUSES
int
default 42
config PCIEXP_HOTPLUG_MEM
hex
default 0xc200000 # 194 MiB
config PCIEXP_HOTPLUG_PREFETCH_MEM
hex
default 0x1c00000 # 448 MiB
Where do these numbers come from?
Removed
Patch Set #3, Line 63: string
Type not needed
Removed
Patch Set #3, Line 67: string
Type not needed
Removed
config DIMM_MAX
int
default 4 # Hack to make soc code work
Huh?
Removed
Type probably not needed
Removed
Patch Set #3, Line 90: string
Type not needed
Removed
File src/mainboard/clevo/tgl-u/board.fmd:
Nothing special here. All handled automatically by build system. Michał you can remove the file.
Removed
File src/mainboard/clevo/tgl-u/bootblock.c:
if (onoff) {
gpio_set(DGPU_RST_N, 0);
mdelay(4);
gpio_set(DGPU_PWR_EN, 1);
mdelay(4);
gpio_set(DGPU_RST_N, 1);
} else {
gpio_set(DGPU_RST_N, 0);
mdelay(4);
gpio_set(DGPU_PWR_EN, 0);
the gpios might be mb specific; we still have APIs to handle that in a generic way
Removed
File src/mainboard/clevo/tgl-u/bootblock.c:
Why not `bool`?
Removed - for now, until the nvidia driver is completed
Patch Set #3, Line 14: static void dgpu_power_enable(int onoff) {
> open brace '{' following function definitions go on the next line […]
Fixed
I'd use `%s` and print `onoff ? "on" : "off"`
Removed
File src/mainboard/clevo/tgl-u/cmos.layout:
Patch Set #3, Line 11: #395 4 e 3 debug_level
Why is this commented out?
Removed
Patch Set #3, Line 12: 408 1 h 1 preserve_smmstore
What does this do?
Removed
File src/mainboard/clevo/tgl-u/dsdt.asl:
Patch Set #3, Line 4: #include <baseboard/gpio.h>
Is it possible to include this from the file that needs it?
File removed
Patch Set #3, Line 12: /* OEM revision */
Is it, though?
Removed
Patch Set #3, Line 36: // Mainboard specific
Redundant comment, please kill with fire
Killed
File src/mainboard/clevo/tgl-u/memory.c:
Rename this file to romstage. […]
Done
File src/mainboard/clevo/tgl-u/romstage.c:
Move this file to variant/nv4x/
Moved
File src/mainboard/clevo/tgl-u/romstage.c:
const uint8_t vtd = get_uint_option("vtd", 1);
memupd->FspmConfig.VtdDisable = !vtd;
const uint8_t ht = get_uint_option("hyper_threading",
memupd->FspmConfig.HyperThreading);
memupd->FspmConfig.HyperThreading = ht;
I don't see these in cmos. […]
Copy-paste error. Removed
File src/mainboard/clevo/tgl-u/variants/baseboard/devicetree.cb:
+1, the concept of `variants/baseboard` gives me aneurysms.
Removed `baseboard` dir
File src/mainboard/clevo/tgl-u/variants/baseboard/include/baseboard/variants.h:
Same here. Move the include folder to mainboard/clevo/tgl-u. […]
Done
To view, visit change 62498. To unsubscribe, or for help writing mail filters, visit settings.