10 comments:
File src/security/intel/stm/StmPlatformResource.h:
Patch Set #44, Line 24: #define LPC_FUNCTION 0
is this still used?
LPC_DEVICE and LPC_FUNCTION are used in StmPlatformResource.c. LPC_BUS has been removed
Patch Set #44, Line 30: SMRR_PHYSBASE_MSR
why aren't those define in msr. […]
all MSR defines have been moved to msr.h
File src/security/intel/stm/StmPlatformResource.c:
Patch Set #44, Line 20: #include <southbridge/intel/common/pmutil.h>
that's only correct for SOUTHBRIDGE_INTEL_COMMON_PMCLIB […]
Done
Patch Set #44, Line 26: uint32_t m_tseg_base;
can be removed. those are only written and read once.
Done
Patch Set #44, Line 31: uint64_t uint64;
can be removed. […]
Done
Patch Set #44, Line 113: #ifndef ACPI_BASE_ADDRESS
Eugene in case there is confusion, please remove the whole commented out block.
Done
Patch Set #44, Line 181: Status = add_pi_resource((void *)&rsc_lpc_bridge_pci, 1);
return code not checked
Done
Patch Set #44, Line 198: Status = add_pi_resource((void *)&rsc_msr_tpl, 1);
return code not checked
Done
File src/security/intel/stm/StmPlatformSmm.c:
Patch Set #44, Line 90: #define SMM_CODE_SEG 0x8
that's not the right place. The other segment defines are in […]
created smm_segs.h
Patch Set #44, Line 181: load_stm_image(mseg);
return code not checked
Done
To view, visit change 33234. To unsubscribe, or for help writing mail filters, visit settings.