View Change
1 comment:
Commit Message:
Patch Set #1, Line 9: Adapted from implementation in sb/intel/common.
Why can’t the common implementation not be used?
the smihandler implementations for sb/common, lynxpoint, broadwell, baytrail, and braswell are all just different enough that it would be problematic to combine them
To view, visit change 39189. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64f520d17146206b8b9b41fc4f827539c5cfd507
Gerrit-Change-Number: 39189
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 02 Mar 2020 15:50:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: comment