Elyes Haouas has uploaded this change for review.

View Change

tree: Use boolean for disable_package_c_state_demotion

Change-Id: I80ad02ca016ad2c8d0bfeb33e8309002dfe723c0
Signed-off-by: Elyes Haouas <ehaouas@noos.fr>
---
M src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb
M src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb
M src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb
M src/mainboard/google/brya/variants/orisa/overridetree.cb
M src/mainboard/google/brya/variants/trulo/overridetree.cb
M src/mainboard/google/rex/variants/baseboard/ovis/devicetree.cb
M src/mainboard/google/rex/variants/baseboard/ovis/devicetree_pre_prod.cb
M src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb
M src/mainboard/google/rex/variants/baseboard/rex/devicetree_pre_prod.cb
M src/mainboard/intel/adlrvp/variants/adlrvp_rpl/overridetree.cb
M src/mainboard/intel/adlrvp/variants/adlrvp_rpl_ext_ec/overridetree.cb
M src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb
M src/mainboard/system76/rpl/devicetree.cb
13 files changed, 13 insertions(+), 13 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/84164/1
diff --git a/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb b/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb
index 4af0063..8904516 100644
--- a/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb
+++ b/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb
@@ -19,7 +19,7 @@

# Disable package C state demotion on Raptorlake as a W/A for S0ix issues
# seen on J0 and Q0 SKUs
- register "disable_package_c_state_demotion" = "1"
+ register "disable_package_c_state_demotion" = "true"

# Disable C1 state auto-demotion for all brox baseboards
register "disable_c1_state_auto_demotion" = "true"
diff --git a/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb b/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb
index 301a216..6160ebf 100644
--- a/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb
+++ b/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb
@@ -16,7 +16,7 @@

# Disable package C state demotion on Raptorlake as a W/A for S0ix issues
# seen on J0 and Q0 SKUs
- register "disable_package_c_state_demotion" = "1"
+ register "disable_package_c_state_demotion" = "true"

# DPTF enable
register "dptf_enable" = "true"
diff --git a/src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb b/src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb
index d2518d6..90677e4 100644
--- a/src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb
+++ b/src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb
@@ -92,7 +92,7 @@

# FIXME: To be enabled in future based on PNP impact data.
# Disable Package C-state demotion for nissa baseboard.
- register "disable_package_c_state_demotion" = "1"
+ register "disable_package_c_state_demotion" = "true"

# Intel Common SoC Config
#+-------------------+---------------------------+
diff --git a/src/mainboard/google/brya/variants/orisa/overridetree.cb b/src/mainboard/google/brya/variants/orisa/overridetree.cb
index f3ad232..cbca871 100644
--- a/src/mainboard/google/brya/variants/orisa/overridetree.cb
+++ b/src/mainboard/google/brya/variants/orisa/overridetree.cb
@@ -142,7 +142,7 @@

# FIXME: To be enabled in future based on PNP impact data.
# Disable Package C-state demotion for nissa baseboard.
- register "disable_package_c_state_demotion" = "1"
+ register "disable_package_c_state_demotion" = "true"

# Intel Common SoC Config
#+-------------------+---------------------------+
diff --git a/src/mainboard/google/brya/variants/trulo/overridetree.cb b/src/mainboard/google/brya/variants/trulo/overridetree.cb
index 6fb91ff..ba97143 100644
--- a/src/mainboard/google/brya/variants/trulo/overridetree.cb
+++ b/src/mainboard/google/brya/variants/trulo/overridetree.cb
@@ -142,7 +142,7 @@

# FIXME: To be enabled in future based on PNP impact data.
# Disable Package C-state demotion for nissa baseboard.
- register "disable_package_c_state_demotion" = "1"
+ register "disable_package_c_state_demotion" = "true"

# Intel Common SoC Config
#+-------------------+---------------------------+
diff --git a/src/mainboard/google/rex/variants/baseboard/ovis/devicetree.cb b/src/mainboard/google/rex/variants/baseboard/ovis/devicetree.cb
index 7158b06..517d17b 100644
--- a/src/mainboard/google/rex/variants/baseboard/ovis/devicetree.cb
+++ b/src/mainboard/google/rex/variants/baseboard/ovis/devicetree.cb
@@ -37,7 +37,7 @@
register "disable_c1_state_auto_demotion" = "true"

# Disable PKGC-state demotion
- register "disable_package_c_state_demotion" = "1"
+ register "disable_package_c_state_demotion" = "true"

# Enable Energy Reporting
register "pch_pm_energy_report_enable" = "1"
diff --git a/src/mainboard/google/rex/variants/baseboard/ovis/devicetree_pre_prod.cb b/src/mainboard/google/rex/variants/baseboard/ovis/devicetree_pre_prod.cb
index e024680..b973cef 100644
--- a/src/mainboard/google/rex/variants/baseboard/ovis/devicetree_pre_prod.cb
+++ b/src/mainboard/google/rex/variants/baseboard/ovis/devicetree_pre_prod.cb
@@ -37,7 +37,7 @@
register "disable_c1_state_auto_demotion" = "true"

# Disable PKGC-state demotion
- register "disable_package_c_state_demotion" = "1"
+ register "disable_package_c_state_demotion" = "true"

# Enable Energy Reporting
register "pch_pm_energy_report_enable" = "1"
diff --git a/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb b/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb
index 248844b..92f2f7f 100644
--- a/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb
+++ b/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb
@@ -37,7 +37,7 @@
register "disable_c1_state_auto_demotion" = "true"

# Disable PKGC-state demotion
- register "disable_package_c_state_demotion" = "1"
+ register "disable_package_c_state_demotion" = "true"

# Enable Energy Reporting
register "pch_pm_energy_report_enable" = "1"
diff --git a/src/mainboard/google/rex/variants/baseboard/rex/devicetree_pre_prod.cb b/src/mainboard/google/rex/variants/baseboard/rex/devicetree_pre_prod.cb
index 7e17ab4..6df6c73 100644
--- a/src/mainboard/google/rex/variants/baseboard/rex/devicetree_pre_prod.cb
+++ b/src/mainboard/google/rex/variants/baseboard/rex/devicetree_pre_prod.cb
@@ -37,7 +37,7 @@
register "disable_c1_state_auto_demotion" = "true"

# Disable PKGC-state demotion
- register "disable_package_c_state_demotion" = "1"
+ register "disable_package_c_state_demotion" = "true"

# Enable Energy Reporting
register "pch_pm_energy_report_enable" = "1"
diff --git a/src/mainboard/intel/adlrvp/variants/adlrvp_rpl/overridetree.cb b/src/mainboard/intel/adlrvp/variants/adlrvp_rpl/overridetree.cb
index 73012d1..8747164 100644
--- a/src/mainboard/intel/adlrvp/variants/adlrvp_rpl/overridetree.cb
+++ b/src/mainboard/intel/adlrvp/variants/adlrvp_rpl/overridetree.cb
@@ -1,7 +1,7 @@
chip soc/intel/alderlake
# Disable package C state demotion on Raptorlake as a W/A for S0ix issues
# seen on J0 and Q0 SKUs
- register "disable_package_c_state_demotion" = "1"
+ register "disable_package_c_state_demotion" = "true"

device domain 0 on end
end
diff --git a/src/mainboard/intel/adlrvp/variants/adlrvp_rpl_ext_ec/overridetree.cb b/src/mainboard/intel/adlrvp/variants/adlrvp_rpl_ext_ec/overridetree.cb
index 8bc35c0..0c62e4c 100644
--- a/src/mainboard/intel/adlrvp/variants/adlrvp_rpl_ext_ec/overridetree.cb
+++ b/src/mainboard/intel/adlrvp/variants/adlrvp_rpl_ext_ec/overridetree.cb
@@ -1,7 +1,7 @@
chip soc/intel/alderlake
# Disable package C state demotion on Raptorlake as a W/A for S0ix issues
# seen on J0 and Q0 SKUs
- register "disable_package_c_state_demotion" = "1"
+ register "disable_package_c_state_demotion" = "true"

device domain 0 on
device ref pch_espi on
diff --git a/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb b/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb
index fd2f4af..2dbceb9 100644
--- a/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb
+++ b/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb
@@ -56,7 +56,7 @@
register "disable_c1_state_auto_demotion" = "true"

# Disable PKGC-state demotion
- register "disable_package_c_state_demotion" = "1"
+ register "disable_package_c_state_demotion" = "true"

# Enable energy reporting
register "pch_pm_energy_report_enable" = "1"
diff --git a/src/mainboard/system76/rpl/devicetree.cb b/src/mainboard/system76/rpl/devicetree.cb
index b5926ef..d6b4650 100644
--- a/src/mainboard/system76/rpl/devicetree.cb
+++ b/src/mainboard/system76/rpl/devicetree.cb
@@ -21,7 +21,7 @@

# Disable package C state demotion on Raptorlake as a W/A for S0ix issues
# seen on J0 and Q0 SKUs
- register "disable_package_c_state_demotion" = "1"
+ register "disable_package_c_state_demotion" = "true"

device domain 0 on
device ref system_agent on end

To view, visit change 84164. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I80ad02ca016ad2c8d0bfeb33e8309002dfe723c0
Gerrit-Change-Number: 84164
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas@noos.fr>