View Change

3 comments:

• File src/soc/sifive/fu540/include/soc/spi.h:

  • Patch Set #13, Line 20:

    #define _ASSERT_SIZEOF(type, size) _Static_assert( \
    		sizeof(type) == (size), \
    		#type " must be " #size " bytes wide")
    

    This macro should ideally be in a non RISC-V-specific directory

  • Patch Set #13, Line 217:

    // Inlining header functions in C
    // https://stackoverflow.com/a/23699777/7433423
    

    This stackoverflow link seems unnecessary, because inlining is a common C feature.

• File src/soc/sifive/fu540/include/soc/spi_flash.h:

  • Patch Set #13, Line 29: */

    That's a lot of functions for a header. Do they have to be in a header?
    Ideally, I'd prefer to have them in a .c file

To view, visit change 30466. To unsubscribe, or for help writing mail filters, visit settings.