Patch Set 3: Code-Review-1

Removing code that you don't fully understand is a surefire way to break things. Don't forget that some registers directly control hardware states, and some other registers (e.g. SCIP on ICH7) can even be changed by the hardware itself!

Indeed, I don't understand...!
I've asked to test on IRC, isn't it ?
I've tested current on my board (desktop version) and I've checked, apple/macbook21 vendore did the same.

So please teach me why we have this loop ?
Thx

View Change

To view, visit change 40369. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iefa53ceaa4fb9dd7868ea59a21d9bd11f3bf27b9
Gerrit-Change-Number: 40369
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 16 Apr 2020 14:38:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment