[coreboot-gerrit] Change in coreboot[master]: nb/intel/i945: Correct mask for CxDRT1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31144 )

Change subject: nb/intel/i945: Correct mask for CxDRT1
......................................................................

Patch Set 6: -Code-Review
> Patch Set 6: Code-Review-1
> > Patch Set 6:
> > > Patch Set 6: Code-Review-1
> > >
> > > "Reserved" in Intel's datasheets means "doesn't concern you"
> > > (which is wrong anyway) but not that the hardware/firmware
> > > doesn't know the bits.
> >
> > indeed, as they are Reserved, we don't have to mask with 0s .
> > I mean
> > Reserved & 1 = Reserved
> > and 
> > Reserved & 0 = 0 
> > (I agree, it isn't a good dialectic, but vendor uses 0xcf020088)
>
> What does vendor do with that value? Is it what gets written to the CxDRT1 registers?

i915 uses 0xcf080488, so I guess these registers are truly unused.