370 comments:
Patch Set #1, Line 194: uint32_t fit_base = (char*)fit - image_region->data + 0x100000000 - image_region->size;
"(foo*)" should be "(foo *)"
Patch Set #1, Line 210: for (unsigned i = 1; i < fit->header.size_reserved; i++) {
Prefer 'unsigned int' to bare use of 'unsigned'
Patch Set #1, Line 226: if (start < fit_base) {
braces {} are not necessary for single statement blocks
Patch Set #1, Line 231: if (start + size > fit_limit) {
braces {} are not necessary for single statement blocks
Patch Set #1, Line 244: char *dst = (char*)&bpm.ibb_element.segment[bpm.ibb_element.ibb_seg_count];
"(foo*)" should be "(foo *)"
Patch Set #1, Line 245: char *src = (char*)&bpm.ibb_element.segment[8];
"(foo*)" should be "(foo *)"
Patch Set #1, Line 246: int size = (char*)(&bpm + 1) - src;
"(foo*)" should be "(foo *)"
Patch Set #1, Line 252: return (bpms_t*)dst;
"(foo*)" should be "(foo *)"
Patch Set #1, Line 259: if ((i%16) == 0) LOG("\n%*c", ident, ' ');
trailing statements should be on next line
Patch Set #1, Line 268: bpms_t *sig = (bpms_t*)&bpm.ibb_element.segment[bpm.ibb_element.ibb_seg_count];
"(foo*)" should be "(foo *)"
Patch Set #1, Line 413: if (!fread(&km, sizeof(km), 1, file) && !feof(file)){
space required before the open brace '{'
Patch Set #1, Line 424: bpms_t *sig = (bpms_t*)&bpm.ibb_element.segment[bpm.ibb_element.ibb_seg_count];
"(foo*)" should be "(foo *)"
Patch Set #1, Line 430: ERROR("Hash of key used for signing BPM **does not match** value in KM\n");
line over 96 characters
Patch Set #1, Line 622: if (params.fit_entries == 0 && params.validate_hash == 0 && params.dump_manifests == 0) {
line over 96 characters
Patch Set #1, Line 663: RSA* privkey = NULL;
"foo* bar" should be "foo *bar"
Patch Set #1, Line 715: if (!(privkey = PEM_read_RSAPrivateKey(file, NULL, NULL, NULL))) {
do not use assignment in if condition
Patch Set #1, Line 725: BPM_KEY_SIZE_BYTES) !=
code indent should use tabs where possible
Patch Set #1, Line 733: unsigned int size = (char*)(new_sig) - (char*)(&bpm);
"(foo*)" should be "(foo *)"
Patch Set #1, Line 733: unsigned int size = (char*)(new_sig) - (char*)(&bpm);
"(foo*)" should be "(foo *)"
Patch Set #1, Line 736: vb2_digest_buffer((unsigned char*)&bpm, size,
"(foo*)" should be "(foo *)"
Patch Set #1, Line 737: VB2_HASH_SHA256, dig, SHA256_DIGEST_SIZE);
code indent should use tabs where possible
Patch Set #1, Line 740: new_sig->key_signature.sig_structure.rsa_sig, &size, privkey);
code indent should use tabs where possible
Patch Set #1, Line 742: if (size != BPM_KEY_SIZE_BYTES) {
braces {} are not necessary for single statement blocks
Patch Set #1, Line 747: size = (char *)(new_sig) - (char*)(&bpm) + sizeof(bpms_t);
"(foo*)" should be "(foo *)"
Patch Set #1, Line 766: VB2_HASH_SHA256, km.bp_key.buf, SHA256_DIGEST_SIZE);
code indent should use tabs where possible
Patch Set #1, Line 775: if (!(privkey = PEM_read_RSAPrivateKey(file, NULL, NULL, NULL))) {
do not use assignment in if condition
Patch Set #1, Line 792: vb2_digest_buffer((unsigned char*)&km, sizeof(km) - sizeof(km.signature),
"(foo*)" should be "(foo *)"
Patch Set #1, Line 793: VB2_HASH_SHA256, dig, SHA256_DIGEST_SIZE);
code indent should use tabs where possible
Patch Set #1, Line 796: km.signature.sig_structure.rsa_sig, &size, privkey);
code indent should use tabs where possible
Patch Set #1, Line 798: if (size != BPM_KEY_SIZE_BYTES) {
braces {} are not necessary for single statement blocks
File util/cbfstool/libcrypto-compat.h:
Patch Set #1, Line 18: void RSA_get0_crt_params(const RSA *r, const BIGNUM **dmp1, const BIGNUM **dmq1, const BIGNUM **iqmp);
line over 96 characters
Patch Set #1, Line 47: int RSA_meth_set_priv_enc(RSA_METHOD *meth, int (*priv_enc) (int flen, const unsigned char *from, unsigned char *to, RSA *rsa, int padding));
line over 96 characters
Patch Set #1, Line 48: int RSA_meth_set_priv_dec(RSA_METHOD *meth, int (*priv_dec) (int flen, const unsigned char *from, unsigned char *to, RSA *rsa, int padding));
line over 96 characters
File util/cbfstool/libcrypto-compat.c:
Patch Set #1, Line 20: void *ret = OPENSSL_malloc(num);
please, no spaces at the start of a line
Patch Set #1, Line 22: if (ret != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 23: memset(ret, 0, num);
code indent should use tabs where possible
Patch Set #1, Line 23: memset(ret, 0, num);
please, no spaces at the start of a line
Patch Set #1, Line 24: return ret;
please, no spaces at the start of a line
Patch Set #1, Line 33: if ((r->n == NULL && n == NULL)
please, no spaces at the start of a line
Patch Set #1, Line 34: || (r->e == NULL && e == NULL))
code indent should use tabs where possible
Patch Set #1, Line 34: || (r->e == NULL && e == NULL))
please, no spaces at the start of a line
Patch Set #1, Line 35: return 0;
code indent should use tabs where possible
Patch Set #1, Line 35: return 0;
please, no spaces at the start of a line
Patch Set #1, Line 37: if (n != NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 38: BN_free(r->n);
code indent should use tabs where possible
Patch Set #1, Line 38: BN_free(r->n);
please, no spaces at the start of a line
Patch Set #1, Line 39: r->n = n;
code indent should use tabs where possible
Patch Set #1, Line 39: r->n = n;
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 41: if (e != NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 42: BN_free(r->e);
code indent should use tabs where possible
Patch Set #1, Line 42: BN_free(r->e);
please, no spaces at the start of a line
Patch Set #1, Line 43: r->e = e;
code indent should use tabs where possible
Patch Set #1, Line 43: r->e = e;
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 45: if (d != NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 46: BN_free(r->d);
code indent should use tabs where possible
Patch Set #1, Line 46: BN_free(r->d);
please, no spaces at the start of a line
Patch Set #1, Line 47: r->d = d;
code indent should use tabs where possible
Patch Set #1, Line 47: r->d = d;
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 50: return 1;
please, no spaces at the start of a line
Patch Set #1, Line 58: if ((r->p == NULL && p == NULL)
please, no spaces at the start of a line
Patch Set #1, Line 59: || (r->q == NULL && q == NULL))
code indent should use tabs where possible
Patch Set #1, Line 59: || (r->q == NULL && q == NULL))
please, no spaces at the start of a line
Patch Set #1, Line 60: return 0;
code indent should use tabs where possible
Patch Set #1, Line 60: return 0;
please, no spaces at the start of a line
Patch Set #1, Line 62: if (p != NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 63: BN_free(r->p);
code indent should use tabs where possible
Patch Set #1, Line 63: BN_free(r->p);
please, no spaces at the start of a line
Patch Set #1, Line 64: r->p = p;
code indent should use tabs where possible
Patch Set #1, Line 64: r->p = p;
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 66: if (q != NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 67: BN_free(r->q);
code indent should use tabs where possible
Patch Set #1, Line 67: BN_free(r->q);
please, no spaces at the start of a line
Patch Set #1, Line 68: r->q = q;
code indent should use tabs where possible
Patch Set #1, Line 68: r->q = q;
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 71: return 1;
please, no spaces at the start of a line
Patch Set #1, Line 79: if ((r->dmp1 == NULL && dmp1 == NULL)
please, no spaces at the start of a line
Patch Set #1, Line 80: || (r->dmq1 == NULL && dmq1 == NULL)
code indent should use tabs where possible
Patch Set #1, Line 80: || (r->dmq1 == NULL && dmq1 == NULL)
please, no spaces at the start of a line
Patch Set #1, Line 81: || (r->iqmp == NULL && iqmp == NULL))
code indent should use tabs where possible
Patch Set #1, Line 81: || (r->iqmp == NULL && iqmp == NULL))
please, no spaces at the start of a line
Patch Set #1, Line 82: return 0;
code indent should use tabs where possible
Patch Set #1, Line 82: return 0;
please, no spaces at the start of a line
Patch Set #1, Line 84: if (dmp1 != NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 85: BN_free(r->dmp1);
code indent should use tabs where possible
Patch Set #1, Line 85: BN_free(r->dmp1);
please, no spaces at the start of a line
Patch Set #1, Line 86: r->dmp1 = dmp1;
code indent should use tabs where possible
Patch Set #1, Line 86: r->dmp1 = dmp1;
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 88: if (dmq1 != NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 89: BN_free(r->dmq1);
code indent should use tabs where possible
Patch Set #1, Line 89: BN_free(r->dmq1);
please, no spaces at the start of a line
Patch Set #1, Line 90: r->dmq1 = dmq1;
code indent should use tabs where possible
Patch Set #1, Line 90: r->dmq1 = dmq1;
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 92: if (iqmp != NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 93: BN_free(r->iqmp);
code indent should use tabs where possible
Patch Set #1, Line 93: BN_free(r->iqmp);
please, no spaces at the start of a line
Patch Set #1, Line 94: r->iqmp = iqmp;
code indent should use tabs where possible
Patch Set #1, Line 94: r->iqmp = iqmp;
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 97: return 1;
please, no spaces at the start of a line
Patch Set #1, Line 101: const BIGNUM **n, const BIGNUM **e, const BIGNUM **d)
code indent should use tabs where possible
Patch Set #1, Line 101: const BIGNUM **n, const BIGNUM **e, const BIGNUM **d)
please, no spaces at the start of a line
Patch Set #1, Line 103: if (n != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 104: *n = r->n;
code indent should use tabs where possible
Patch Set #1, Line 104: *n = r->n;
please, no spaces at the start of a line
Patch Set #1, Line 105: if (e != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 106: *e = r->e;
code indent should use tabs where possible
Patch Set #1, Line 106: *e = r->e;
please, no spaces at the start of a line
Patch Set #1, Line 107: if (d != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 108: *d = r->d;
code indent should use tabs where possible
Patch Set #1, Line 108: *d = r->d;
please, no spaces at the start of a line
Patch Set #1, Line 113: if (p != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 114: *p = r->p;
code indent should use tabs where possible
Patch Set #1, Line 114: *p = r->p;
please, no spaces at the start of a line
Patch Set #1, Line 115: if (q != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 116: *q = r->q;
code indent should use tabs where possible
Patch Set #1, Line 116: *q = r->q;
please, no spaces at the start of a line
Patch Set #1, Line 120: const BIGNUM **dmp1, const BIGNUM **dmq1,
code indent should use tabs where possible
Patch Set #1, Line 120: const BIGNUM **dmp1, const BIGNUM **dmq1,
please, no spaces at the start of a line
Patch Set #1, Line 121: const BIGNUM **iqmp)
code indent should use tabs where possible
Patch Set #1, Line 121: const BIGNUM **iqmp)
please, no spaces at the start of a line
Patch Set #1, Line 123: if (dmp1 != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 124: *dmp1 = r->dmp1;
code indent should use tabs where possible
Patch Set #1, Line 124: *dmp1 = r->dmp1;
please, no spaces at the start of a line
Patch Set #1, Line 125: if (dmq1 != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 126: *dmq1 = r->dmq1;
code indent should use tabs where possible
Patch Set #1, Line 126: *dmq1 = r->dmq1;
please, no spaces at the start of a line
Patch Set #1, Line 127: if (iqmp != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 128: *iqmp = r->iqmp;
code indent should use tabs where possible
Patch Set #1, Line 128: *iqmp = r->iqmp;
please, no spaces at the start of a line
Patch Set #1, Line 132: const BIGNUM **p, const BIGNUM **q, const BIGNUM **g)
code indent should use tabs where possible
Patch Set #1, Line 132: const BIGNUM **p, const BIGNUM **q, const BIGNUM **g)
please, no spaces at the start of a line
Patch Set #1, Line 134: if (p != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 135: *p = d->p;
code indent should use tabs where possible
Patch Set #1, Line 135: *p = d->p;
please, no spaces at the start of a line
Patch Set #1, Line 136: if (q != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 137: *q = d->q;
code indent should use tabs where possible
Patch Set #1, Line 137: *q = d->q;
please, no spaces at the start of a line
Patch Set #1, Line 138: if (g != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 139: *g = d->g;
code indent should use tabs where possible
Patch Set #1, Line 139: *g = d->g;
please, no spaces at the start of a line
Patch Set #1, Line 147: if ((d->p == NULL && p == NULL)
please, no spaces at the start of a line
Patch Set #1, Line 148: || (d->q == NULL && q == NULL)
code indent should use tabs where possible
Patch Set #1, Line 148: || (d->q == NULL && q == NULL)
please, no spaces at the start of a line
Patch Set #1, Line 149: || (d->g == NULL && g == NULL))
code indent should use tabs where possible
Patch Set #1, Line 149: || (d->g == NULL && g == NULL))
please, no spaces at the start of a line
Patch Set #1, Line 150: return 0;
code indent should use tabs where possible
Patch Set #1, Line 150: return 0;
please, no spaces at the start of a line
Patch Set #1, Line 152: if (p != NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 153: BN_free(d->p);
code indent should use tabs where possible
Patch Set #1, Line 153: BN_free(d->p);
please, no spaces at the start of a line
Patch Set #1, Line 154: d->p = p;
code indent should use tabs where possible
Patch Set #1, Line 154: d->p = p;
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 156: if (q != NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 157: BN_free(d->q);
code indent should use tabs where possible
Patch Set #1, Line 157: BN_free(d->q);
please, no spaces at the start of a line
Patch Set #1, Line 158: d->q = q;
code indent should use tabs where possible
Patch Set #1, Line 158: d->q = q;
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 160: if (g != NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 161: BN_free(d->g);
code indent should use tabs where possible
Patch Set #1, Line 161: BN_free(d->g);
please, no spaces at the start of a line
Patch Set #1, Line 162: d->g = g;
code indent should use tabs where possible
Patch Set #1, Line 162: d->g = g;
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 165: return 1;
please, no spaces at the start of a line
Patch Set #1, Line 169: const BIGNUM **pub_key, const BIGNUM **priv_key)
code indent should use tabs where possible
Patch Set #1, Line 169: const BIGNUM **pub_key, const BIGNUM **priv_key)
please, no spaces at the start of a line
Patch Set #1, Line 171: if (pub_key != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 172: *pub_key = d->pub_key;
code indent should use tabs where possible
Patch Set #1, Line 172: *pub_key = d->pub_key;
please, no spaces at the start of a line
Patch Set #1, Line 173: if (priv_key != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 174: *priv_key = d->priv_key;
code indent should use tabs where possible
Patch Set #1, Line 174: *priv_key = d->priv_key;
please, no spaces at the start of a line
Patch Set #1, Line 183: if (d->pub_key == NULL && pub_key == NULL)
please, no spaces at the start of a line
Patch Set #1, Line 184: return 0;
code indent should use tabs where possible
Patch Set #1, Line 184: return 0;
please, no spaces at the start of a line
Patch Set #1, Line 186: if (pub_key != NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 187: BN_free(d->pub_key);
code indent should use tabs where possible
Patch Set #1, Line 187: BN_free(d->pub_key);
please, no spaces at the start of a line
Patch Set #1, Line 188: d->pub_key = pub_key;
code indent should use tabs where possible
Patch Set #1, Line 188: d->pub_key = pub_key;
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 190: if (priv_key != NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 191: BN_free(d->priv_key);
code indent should use tabs where possible
Patch Set #1, Line 191: BN_free(d->priv_key);
please, no spaces at the start of a line
Patch Set #1, Line 192: d->priv_key = priv_key;
code indent should use tabs where possible
Patch Set #1, Line 192: d->priv_key = priv_key;
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 195: return 1;
please, no spaces at the start of a line
Patch Set #1, Line 200: if (pr != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 201: *pr = sig->r;
code indent should use tabs where possible
Patch Set #1, Line 201: *pr = sig->r;
please, no spaces at the start of a line
Patch Set #1, Line 202: if (ps != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 203: *ps = sig->s;
code indent should use tabs where possible
Patch Set #1, Line 203: *ps = sig->s;
please, no spaces at the start of a line
Patch Set #1, Line 208: if (r == NULL || s == NULL)
please, no spaces at the start of a line
Patch Set #1, Line 209: return 0;
code indent should use tabs where possible
Patch Set #1, Line 209: return 0;
please, no spaces at the start of a line
Patch Set #1, Line 210: BN_clear_free(sig->r);
please, no spaces at the start of a line
Patch Set #1, Line 211: BN_clear_free(sig->s);
please, no spaces at the start of a line
Patch Set #1, Line 212: sig->r = r;
please, no spaces at the start of a line
Patch Set #1, Line 213: sig->s = s;
please, no spaces at the start of a line
Patch Set #1, Line 214: return 1;
please, no spaces at the start of a line
Patch Set #1, Line 219: if (pr != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 220: *pr = sig->r;
code indent should use tabs where possible
Patch Set #1, Line 220: *pr = sig->r;
please, no spaces at the start of a line
Patch Set #1, Line 221: if (ps != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 222: *ps = sig->s;
code indent should use tabs where possible
Patch Set #1, Line 222: *ps = sig->s;
please, no spaces at the start of a line
Patch Set #1, Line 227: if (r == NULL || s == NULL)
please, no spaces at the start of a line
Patch Set #1, Line 228: return 0;
code indent should use tabs where possible
Patch Set #1, Line 228: return 0;
please, no spaces at the start of a line
Patch Set #1, Line 229: BN_clear_free(sig->r);
please, no spaces at the start of a line
Patch Set #1, Line 230: BN_clear_free(sig->s);
please, no spaces at the start of a line
Patch Set #1, Line 231: sig->r = r;
please, no spaces at the start of a line
Patch Set #1, Line 232: sig->s = s;
please, no spaces at the start of a line
Patch Set #1, Line 233: return 1;
please, no spaces at the start of a line
Patch Set #1, Line 237: const BIGNUM **p, const BIGNUM **q, const BIGNUM **g)
code indent should use tabs where possible
Patch Set #1, Line 237: const BIGNUM **p, const BIGNUM **q, const BIGNUM **g)
please, no spaces at the start of a line
Patch Set #1, Line 239: if (p != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 240: *p = dh->p;
code indent should use tabs where possible
Patch Set #1, Line 240: *p = dh->p;
please, no spaces at the start of a line
Patch Set #1, Line 241: if (q != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 242: *q = dh->q;
code indent should use tabs where possible
Patch Set #1, Line 242: *q = dh->q;
please, no spaces at the start of a line
Patch Set #1, Line 243: if (g != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 244: *g = dh->g;
code indent should use tabs where possible
Patch Set #1, Line 244: *g = dh->g;
please, no spaces at the start of a line
Patch Set #1, Line 252: if ((dh->p == NULL && p == NULL)
please, no spaces at the start of a line
Patch Set #1, Line 253: || (dh->g == NULL && g == NULL))
code indent should use tabs where possible
Patch Set #1, Line 253: || (dh->g == NULL && g == NULL))
please, no spaces at the start of a line
Patch Set #1, Line 254: return 0;
code indent should use tabs where possible
Patch Set #1, Line 254: return 0;
please, no spaces at the start of a line
Patch Set #1, Line 256: if (p != NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 257: BN_free(dh->p);
code indent should use tabs where possible
Patch Set #1, Line 257: BN_free(dh->p);
please, no spaces at the start of a line
Patch Set #1, Line 258: dh->p = p;
code indent should use tabs where possible
Patch Set #1, Line 258: dh->p = p;
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 260: if (q != NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 261: BN_free(dh->q);
code indent should use tabs where possible
Patch Set #1, Line 261: BN_free(dh->q);
please, no spaces at the start of a line
Patch Set #1, Line 262: dh->q = q;
code indent should use tabs where possible
Patch Set #1, Line 262: dh->q = q;
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 264: if (g != NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 265: BN_free(dh->g);
code indent should use tabs where possible
Patch Set #1, Line 265: BN_free(dh->g);
please, no spaces at the start of a line
Patch Set #1, Line 266: dh->g = g;
code indent should use tabs where possible
Patch Set #1, Line 266: dh->g = g;
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 269: if (q != NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 269: if (q != NULL) {
braces {} are not necessary for single statement blocks
Patch Set #1, Line 270: dh->length = BN_num_bits(q);
code indent should use tabs where possible
Patch Set #1, Line 270: dh->length = BN_num_bits(q);
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 273: return 1;
please, no spaces at the start of a line
Patch Set #1, Line 278: if (pub_key != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 279: *pub_key = dh->pub_key;
code indent should use tabs where possible
Patch Set #1, Line 279: *pub_key = dh->pub_key;
please, no spaces at the start of a line
Patch Set #1, Line 280: if (priv_key != NULL)
please, no spaces at the start of a line
Patch Set #1, Line 281: *priv_key = dh->priv_key;
code indent should use tabs where possible
Patch Set #1, Line 281: *priv_key = dh->priv_key;
please, no spaces at the start of a line
Patch Set #1, Line 290: if (dh->pub_key == NULL && pub_key == NULL)
please, no spaces at the start of a line
Patch Set #1, Line 291: return 0;
code indent should use tabs where possible
Patch Set #1, Line 291: return 0;
please, no spaces at the start of a line
Patch Set #1, Line 293: if (pub_key != NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 294: BN_free(dh->pub_key);
code indent should use tabs where possible
Patch Set #1, Line 294: BN_free(dh->pub_key);
please, no spaces at the start of a line
Patch Set #1, Line 295: dh->pub_key = pub_key;
code indent should use tabs where possible
Patch Set #1, Line 295: dh->pub_key = pub_key;
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 297: if (priv_key != NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 298: BN_free(dh->priv_key);
code indent should use tabs where possible
Patch Set #1, Line 298: BN_free(dh->priv_key);
please, no spaces at the start of a line
Patch Set #1, Line 299: dh->priv_key = priv_key;
code indent should use tabs where possible
Patch Set #1, Line 299: dh->priv_key = priv_key;
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 302: return 1;
please, no spaces at the start of a line
Patch Set #1, Line 307: dh->length = length;
please, no spaces at the start of a line
Patch Set #1, Line 308: return 1;
please, no spaces at the start of a line
Patch Set #1, Line 313: return ctx->iv;
please, no spaces at the start of a line
Patch Set #1, Line 318: return ctx->iv;
please, no spaces at the start of a line
Patch Set #1, Line 323: return OPENSSL_zalloc(sizeof(EVP_MD_CTX));
please, no spaces at the start of a line
Patch Set #1, Line 328: EVP_MD_CTX_cleanup(ctx);
please, no spaces at the start of a line
Patch Set #1, Line 329: OPENSSL_free(ctx);
please, no spaces at the start of a line
Patch Set #1, Line 334: RSA_METHOD *ret;
please, no spaces at the start of a line
Patch Set #1, Line 336: ret = OPENSSL_malloc(sizeof(RSA_METHOD));
please, no spaces at the start of a line
Patch Set #1, Line 338: if (ret != NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 339: memcpy(ret, meth, sizeof(*meth));
code indent should use tabs where possible
Patch Set #1, Line 339: memcpy(ret, meth, sizeof(*meth));
please, no spaces at the start of a line
Patch Set #1, Line 340: ret->name = OPENSSL_strdup(meth->name);
code indent should use tabs where possible
Patch Set #1, Line 340: ret->name = OPENSSL_strdup(meth->name);
please, no spaces at the start of a line
Patch Set #1, Line 341: if (ret->name == NULL) {
code indent should use tabs where possible
Patch Set #1, Line 341: if (ret->name == NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 341: if (ret->name == NULL) {
suspect code indent for conditional statements (8, 12)
Patch Set #1, Line 342: OPENSSL_free(ret);
code indent should use tabs where possible
Patch Set #1, Line 342: OPENSSL_free(ret);
please, no spaces at the start of a line
Patch Set #1, Line 343: return NULL;
code indent should use tabs where possible
Patch Set #1, Line 343: return NULL;
please, no spaces at the start of a line
code indent should use tabs where possible
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 347: return ret;
please, no spaces at the start of a line
Patch Set #1, Line 352: char *tmpname;
please, no spaces at the start of a line
Patch Set #1, Line 354: tmpname = OPENSSL_strdup(name);
please, no spaces at the start of a line
Patch Set #1, Line 355: if (tmpname == NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 355: if (tmpname == NULL) {
braces {} are not necessary for single statement blocks
Patch Set #1, Line 356: return 0;
code indent should use tabs where possible
Patch Set #1, Line 356: return 0;
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 359: OPENSSL_free((void *)(uintptr_t)meth->name);
please, no spaces at the start of a line
Patch Set #1, Line 360: meth->name = tmpname;
please, no spaces at the start of a line
Patch Set #1, Line 362: return 1;
please, no spaces at the start of a line
Patch Set #1, Line 366: int (*priv_enc) (int flen, const unsigned char *from,
code indent should use tabs where possible
Patch Set #1, Line 366: int (*priv_enc) (int flen, const unsigned char *from,
please, no spaces at the start of a line
Patch Set #1, Line 366: int (*priv_enc) (int flen, const unsigned char *from,
Unnecessary space before function pointer arguments
Patch Set #1, Line 367: unsigned char *to, RSA *rsa,
code indent should use tabs where possible
Patch Set #1, Line 367: unsigned char *to, RSA *rsa,
please, no spaces at the start of a line
Patch Set #1, Line 368: int padding))
code indent should use tabs where possible
Patch Set #1, Line 368: int padding))
please, no spaces at the start of a line
Patch Set #1, Line 370: meth->rsa_priv_enc = priv_enc;
please, no spaces at the start of a line
Patch Set #1, Line 371: return 1;
please, no spaces at the start of a line
Patch Set #1, Line 375: int (*priv_dec) (int flen, const unsigned char *from,
code indent should use tabs where possible
Patch Set #1, Line 375: int (*priv_dec) (int flen, const unsigned char *from,
please, no spaces at the start of a line
Patch Set #1, Line 375: int (*priv_dec) (int flen, const unsigned char *from,
Unnecessary space before function pointer arguments
Patch Set #1, Line 376: unsigned char *to, RSA *rsa,
code indent should use tabs where possible
Patch Set #1, Line 376: unsigned char *to, RSA *rsa,
please, no spaces at the start of a line
Patch Set #1, Line 377: int padding))
code indent should use tabs where possible
Patch Set #1, Line 377: int padding))
please, no spaces at the start of a line
Patch Set #1, Line 379: meth->rsa_priv_dec = priv_dec;
please, no spaces at the start of a line
Patch Set #1, Line 380: return 1;
please, no spaces at the start of a line
Patch Set #1, Line 385: meth->finish = finish;
please, no spaces at the start of a line
Patch Set #1, Line 386: return 1;
please, no spaces at the start of a line
Patch Set #1, Line 391: if (meth != NULL) {
please, no spaces at the start of a line
Patch Set #1, Line 392: OPENSSL_free((void *)(uintptr_t)meth->name);
code indent should use tabs where possible
Patch Set #1, Line 392: OPENSSL_free((void *)(uintptr_t)meth->name);
please, no spaces at the start of a line
Patch Set #1, Line 393: OPENSSL_free(meth);
code indent should use tabs where possible
Patch Set #1, Line 393: OPENSSL_free(meth);
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 399: return (BN_num_bits(r->n));
please, no spaces at the start of a line
Patch Set #1, Line 399: return (BN_num_bits(r->n));
return is not a function, parentheses are not required
Patch Set #1, Line 404: if (pkey->type != EVP_PKEY_RSA) {
please, no spaces at the start of a line
Patch Set #1, Line 404: if (pkey->type != EVP_PKEY_RSA) {
braces {} are not necessary for single statement blocks
Patch Set #1, Line 405: return NULL;
code indent should use tabs where possible
Patch Set #1, Line 405: return NULL;
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 407: return pkey->pkey.rsa;
please, no spaces at the start of a line
Patch Set #1, Line 412: if (tolen < BN_num_bytes(a))
please, no spaces at the start of a line
Patch Set #1, Line 413: return -1;
code indent should use tabs where possible
Patch Set #1, Line 413: return -1;
please, no spaces at the start of a line
Patch Set #1, Line 415: memset(to, 0, tolen);
please, no spaces at the start of a line
Patch Set #1, Line 417: int size = BN_bn2bin(a, to);
please, no spaces at the start of a line
Patch Set #1, Line 419: for (int i = 0; i < size/2; i++) {
please, no spaces at the start of a line
Patch Set #1, Line 420: unsigned char tmp = to[i];
code indent should use tabs where possible
Patch Set #1, Line 420: unsigned char tmp = to[i];
please, no spaces at the start of a line
Patch Set #1, Line 421: to[i] = to[size - i - 1];
code indent should use tabs where possible
Patch Set #1, Line 421: to[i] = to[size - i - 1];
please, no spaces at the start of a line
Patch Set #1, Line 422: to[size - i - 1] = tmp;
code indent should use tabs where possible
Patch Set #1, Line 422: to[size - i - 1] = tmp;
please, no spaces at the start of a line
please, no spaces at the start of a line
Patch Set #1, Line 425: return size;
please, no spaces at the start of a line
To view, visit change 43403. To unsubscribe, or for help writing mail filters, visit settings.