Arthur Heymans submitted this change.

View Change


Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
arch/x86: x86_64 implies SSE2 support

Enable SSE2 (and SSE) when compiling for x86_64. Compilers often assume
SSE2 is present and enabled when targeting x86_64.

This fixes:
- lzma decompression code is compiled with the -Ofast flag
- 'everything' when compiling with clang.

This mostly affects qemu targets, which did not have this flag selected
yet.

TESTED on qemu.

Change-Id: I3cdc584c97016e15513df663a54a7bdb549a73e4
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44869
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Elyes Haouas <ehaouas@noos.fr>
---
M src/arch/x86/Kconfig
1 file changed, 32 insertions(+), 0 deletions(-)

diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig
index c00eb0c..b60f600 100644
--- a/src/arch/x86/Kconfig
+++ b/src/arch/x86/Kconfig
@@ -39,19 +39,24 @@

config ARCH_BOOTBLOCK_X86_64
bool
+ select SSE2

config ARCH_VERSTAGE_X86_64
bool
+ select SSE2

config ARCH_ROMSTAGE_X86_64
bool
+ select SSE2

config ARCH_POSTCAR_X86_64
bool
default ARCH_ROMSTAGE_X86_64 && POSTCAR_STAGE
+ select SSE2

config ARCH_RAMSTAGE_X86_64
bool
+ select SSE2

config ARCH_ALL_STAGES_X86_64
bool

To view, visit change 44869. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3cdc584c97016e15513df663a54a7bdb549a73e4
Gerrit-Change-Number: 44869
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Elyes Haouas <ehaouas@noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged