Hello Jude, thanks for your patch. Do you intend to upstream it
to Linux? Also, I'm curious, is this fixing an actual issues or
is it only about cosmetics?

View Change

3 comments:

• File util/kconfig/nconf.c:

  • Patch Set #2, Line 570:

    int kmi_str_len; /* length of initial string */
    	int str_space; /* length of unused space in string */
    

    These could be `size_t`.

  • Patch Set #2, Line 577: kmi_str_len = strlen(k_menu_items[index].str);

    Using strnlen() would avoid potential overflows if .str isn't properly terminated.

  • Patch Set #2, Line 589: k_menu_items[index].str);

    This is oddly indented (and I don't see how changing this makes anything better).

To view, visit change 37939. To unsubscribe, or for help writing mail filters, visit settings.