3 comments:
File src/soc/intel/cannonlake/cnl_memcfg_init.c:
Patch Set #13, Line 57: static size_t last_set_spd_data_len;
You should explicitly initialize the variable to 0.
Patch Set #13, Line 59: assert(spd_data_ptr && spd_data_len);
Please explicitly test spd_data_len != 0 instead of relying on C language behavior to convert an integer from zero/non-zero to false/true.
Patch Set #13, Line 61: if (last_set_spd_data_len && last_set_spd_data_len != spd_data_len)
Please explicitly test last_set_spd_data_len != 0. Also, this could fail if last_set_spd_data_len is uninitialized and you happen to get something non-zero in that memory.
To view, visit change 32513. To unsubscribe, or for help writing mail filters, visit settings.