View Change

10 comments:

• Commit Message:

  • Patch Set #4, Line 9: replace

    To me, "replace X with Y" is "s/X/Y" in vim-speech. I'd rather say "use coreboot-provided inb/outb/rdtsc"

• File src/southbridge/amd/agesa/hudson/smbus_spd.c:

  • Patch Set #3, Line 20: /* warning: Porting.h includes an open #pragma pack(1) */

    Ok.. What this does is nasty. It changes structs to __packed for the remaining of the headers. […]

    #pragma cursed

• File src/southbridge/amd/agesa/hudson/smbus_spd.c:

  • Patch Set #4, Line 26: readSmbusByteData

    These things might need a rename

  • Patch Set #4, Line 27: int offset)

    But this still fits in 96 chars?

  • Patch Set #4, Line 43: limit = rdtscll() + 2000000000 / 10;

    This is reinventing the wheel, there should be a timer API somewhere.

  • Patch Set #4, Line 60:

    if (status == 2)
    		status = 0;
    	return status;
    

    this could even be:

     return status == 2 ? 0 : status;

  • Patch Set #4, Line 80: {

    Please pick this up (should be on the previous line)

  • Patch Set #4, Line 112: printk(BIOS_SPEW, "-------------READING SPD-----------\n");

    Good thing nobody sees this by default (I hope)

  • Patch Set #4, Line 139: ioBase

    This variable should be lowercase

• File src/southbridge/amd/pi/hudson/smbus_spd.c:

  • Patch Set #4:

    Am I drunk? I think I see double. Aren't these files basically the same thing?

To view, visit change 38163. To unsubscribe, or for help writing mail filters, visit settings.