View Change

2 comments:

• File src/vendorcode/amd/agesa/f16kb/Proc/CPU/Family/0x16/cpuF16MmioMap.c:

  • Patch Set #1, Line 226: if (MmioPair >= (MMIO_REG_PAIR_NUM - 1)) {

    Why not: MmmioPair > MMIO_REG_PAIR_NUM

    I moved the `i` init further up to hopefully make
    more clear. Checking here to avoid attempt to
    read MmioRange[i + 1] inside the FOR loop, if
    program flow makes it here with MmioPair == 11.
    The `>` is probably superfluous (there should be
    no way to get here with an MmioPair > 11), but
    left it in since we're making a comparison anyway.

  • Patch Set #1, Line 227: IDS_HDT_CONSOLE (MAIN_FLOW, " [ERROR] Not enough MMIO register pairs to hold the request.\n");

    Please add the values to the error message.

    Done

To view, visit change 38466. To unsubscribe, or for help writing mail filters, visit settings.