Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Tim Chu.
Felix Held has uploaded this change for review.
lib/smbios: add segment_group parameter to smbios_write_type9
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I48b393913913db8436f5cbca04d7411e68a53cf7
---
M src/include/smbios.h
M src/lib/smbios.c
M src/mainboard/ocp/deltalake/ramstage.c
3 files changed, 7 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/79925/1
diff --git a/src/include/smbios.h b/src/include/smbios.h
index f02b48b..f821980 100644
--- a/src/include/smbios.h
+++ b/src/include/smbios.h
@@ -32,7 +32,8 @@
const enum slot_data_bus_bandwidth bandwidth,
const enum misc_slot_usage usage,
const enum misc_slot_length length,
- const u16 id, u8 slot_char1, u8 slot_char2, u8 bus, u8 dev_func);
+ const u16 id, u8 slot_char1, u8 slot_char2,
+ u8 segment_group, u8 bus, u8 dev_func);
enum smbios_bmc_interface_type;
int smbios_write_type38(unsigned long *current, int *handle,
const enum smbios_bmc_interface_type interface_type,
diff --git a/src/lib/smbios.c b/src/lib/smbios.c
index 3ef3c21..fb68b4f 100644
--- a/src/lib/smbios.c
+++ b/src/lib/smbios.c
@@ -639,7 +639,8 @@
const enum slot_data_bus_bandwidth bandwidth,
const enum misc_slot_usage usage,
const enum misc_slot_length length,
- const u16 id, u8 slot_char1, u8 slot_char2, u8 bus, u8 dev_func)
+ const u16 id, u8 slot_char1, u8 slot_char2,
+ u8 segment_group, u8 bus, u8 dev_func)
{
struct smbios_type9 *t = smbios_carve_table(*current, SMBIOS_SYSTEM_SLOTS,
sizeof(*t), *handle);
@@ -653,7 +654,7 @@
t->slot_length = length;
t->slot_characteristics_1 = slot_char1;
t->slot_characteristics_2 = slot_char2;
- t->segment_group_number = 0;
+ t->segment_group_number = segment_group;
t->bus_number = bus;
t->device_function_number = dev_func;
t->data_bus_width = SlotDataBusWidthOther;
@@ -1166,6 +1167,7 @@
0,
1,
0,
+ 0,
dev->bus->secondary,
dev->path.pci.devfn);
}
diff --git a/src/mainboard/ocp/deltalake/ramstage.c b/src/mainboard/ocp/deltalake/ramstage.c
index d553392..c24d004 100644
--- a/src/mainboard/ocp/deltalake/ramstage.c
+++ b/src/mainboard/ocp/deltalake/ramstage.c
@@ -278,6 +278,7 @@
slot_id,
characteristics_1,
characteristics_2,
+ 0, /* segment group */
stack_busnos[slotinfo[index].stack],
slotinfo[index].dev_func);
}
To view, visit change 79925. To unsubscribe, or for help writing mail filters, visit settings.