Attention is currently required from: Christian Walter, Cliff Huang, Jan Samek, Julius Werner, Jérémy Compostella, Krystian Hebel, Lance Zhao, Martin L Roth, Sergii Dmytruk, Tim Wawrzynczak.

View Change

1 comment:

• File src/acpi/acpi.c:

  • Patch Set #31, Line 254:

    static bool is_crb_active(void)
    {
    	uint64_t tpm_status = read64(CRB_REG(0, CRB_REG_INTF_ID));
    
    	if ((tpm_status & CRB_INTF_REG_CAP_CRB) == 0) {
    		printk(BIOS_DEBUG, "ACPI: TPM: CRB Interface is not supported.\n");
    		return false;
    	}
    
    	if ((tpm_status & 0xf) != 1) {
    		printk(BIOS_DEBUG, "ACPI: TPM: CRB Interface is not active.\n");
    		return false;
    	}
    
    	return true;
    }
    
    

    This function could probably find a better place to live.

    I was thinking about src/drivers/crb/tpm.c
    The declaration could be added to src/security/tpm/tss.h

    The compiler would optimize the flow if CRB_TPM is not set, so
    `is_crb_active` would not be compiled in and called anyways.

To view, visit change 69161. To unsubscribe, or for help writing mail filters, visit settings.