Attention is currently required from: Patrick Rudolph.
1 comment:
File src/cpu/x86/64bit/pt.S:
Patch Set #1, Line 14: .align 32
This is the alignment relative to _program. Shouldn't all CBFS files using this assembly code then be aligned to 4096 as well?
Does it work for bootblock where _eprogram is aligned to 4GiB instead of _program?
So bootblock is a special program. It is linked at the address it gets executed, which means this just works. Other programs should be aligned to 4096, which would be cbfstool's job.
Relocatable stages already have 4K runtime alignment afaict: https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src/lib/rmodule.c.
So the only thing left to do is 4K alignment for early programs, especially those that are XIP.
Anyway RO/part of program PT are not always needed. We might need to differentiate:
To view, visit change 56096. To unsubscribe, or for help writing mail filters, visit settings.