That these share the same declaration raises a question:
Why have 6 copies of the (nearly) same code in the first place?

The same thing happens for pretty much every cpu/soc, not just the 7 here. Initialisers of struct mp_ops are split across two or more files, otherwise we would just declare the functions with static together in the same file with const initialiser of mp_ops, right?

Yeah, I see the pattern. I just want to make sure that this
doesn't become a copy-pasta supporting change. There is some
more weirdness, e.g. smm_lock() seems to be declared somewhere
in arch/x86/ already. I'm not sure if it's the same function.

It's just hard to draw a line, imho. But I would like to keep
it to the functions that are directly pointed to by `mp_ops`.
smm_lock() and smm_relocate() seem more implementation specific.

View Change

To view, visit change 34152. To unsubscribe, or for help writing mail filters, visit settings.