Angel Pons has uploaded this change for review.

View Change

src: Drop meaningless `CPU_X86_TSC` symbol

The CPUs currently selecting it do not select `UDELAY_TSC`.

Change-Id: Ie9961228ff0f32bb5ea7fdf4f0dc06adba35b122
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
---
M src/cpu/amd/agesa/family14/Kconfig
M src/cpu/amd/agesa/family15tn/Kconfig
M src/cpu/amd/agesa/family16kb/Kconfig
M src/cpu/amd/pi/00630F01/Kconfig
M src/cpu/amd/pi/00660F01/Kconfig
M src/cpu/amd/pi/00730F01/Kconfig
M src/cpu/x86/Kconfig
M src/cpu/x86/Makefile.inc
M src/soc/amd/stoneyridge/Kconfig
9 files changed, 1 insertion(+), 13 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/44313/1
diff --git a/src/cpu/amd/agesa/family14/Kconfig b/src/cpu/amd/agesa/family14/Kconfig
index 8667602..de8e326 100644
--- a/src/cpu/amd/agesa/family14/Kconfig
+++ b/src/cpu/amd/agesa/family14/Kconfig
@@ -6,7 +6,6 @@
select CPU_X86_LAPIC
select CPU_X86_MTRR
select CPU_X86_SMM
- select CPU_X86_TSC
select X86_AMD_FIXED_MTRRS

if CPU_AMD_AGESA_FAMILY14
diff --git a/src/cpu/amd/agesa/family15tn/Kconfig b/src/cpu/amd/agesa/family15tn/Kconfig
index 4b6b40e..df7ac26 100644
--- a/src/cpu/amd/agesa/family15tn/Kconfig
+++ b/src/cpu/amd/agesa/family15tn/Kconfig
@@ -6,7 +6,6 @@
select CPU_X86_LAPIC
select CPU_X86_MTRR
select CPU_X86_SMM
- select CPU_X86_TSC
select X86_AMD_FIXED_MTRRS

if CPU_AMD_AGESA_FAMILY15_TN
diff --git a/src/cpu/amd/agesa/family16kb/Kconfig b/src/cpu/amd/agesa/family16kb/Kconfig
index 1b43dbe..0cafdf5 100644
--- a/src/cpu/amd/agesa/family16kb/Kconfig
+++ b/src/cpu/amd/agesa/family16kb/Kconfig
@@ -6,7 +6,6 @@
select CPU_X86_LAPIC
select CPU_X86_MTRR
select CPU_X86_SMM
- select CPU_X86_TSC
select X86_AMD_FIXED_MTRRS

if CPU_AMD_AGESA_FAMILY16_KB
diff --git a/src/cpu/amd/pi/00630F01/Kconfig b/src/cpu/amd/pi/00630F01/Kconfig
index db921c3..65f66df 100644
--- a/src/cpu/amd/pi/00630F01/Kconfig
+++ b/src/cpu/amd/pi/00630F01/Kconfig
@@ -6,7 +6,6 @@
select CPU_X86_LAPIC
select CPU_X86_MTRR
select CPU_X86_SMM
- select CPU_X86_TSC
select X86_AMD_FIXED_MTRRS

if CPU_AMD_PI_00630F01
diff --git a/src/cpu/amd/pi/00660F01/Kconfig b/src/cpu/amd/pi/00660F01/Kconfig
index 859dda0..4b7a665 100644
--- a/src/cpu/amd/pi/00660F01/Kconfig
+++ b/src/cpu/amd/pi/00660F01/Kconfig
@@ -6,7 +6,6 @@
select CPU_X86_LAPIC
select CPU_X86_MTRR
select CPU_X86_SMM
- select CPU_X86_TSC
select X86_AMD_FIXED_MTRRS

if CPU_AMD_PI_00660F01
diff --git a/src/cpu/amd/pi/00730F01/Kconfig b/src/cpu/amd/pi/00730F01/Kconfig
index c8c6e0a..4247189 100644
--- a/src/cpu/amd/pi/00730F01/Kconfig
+++ b/src/cpu/amd/pi/00730F01/Kconfig
@@ -6,7 +6,6 @@
select CPU_X86_LAPIC
select CPU_X86_MTRR
select CPU_X86_SMM
- select CPU_X86_TSC
select X86_AMD_FIXED_MTRRS
select SUPPORT_CPU_UCODE_IN_CBFS
select MICROCODE_BLOB_UNDISCLOSED
diff --git a/src/cpu/x86/Kconfig b/src/cpu/x86/Kconfig
index 8d1dfa6..dddd911 100644
--- a/src/cpu/x86/Kconfig
+++ b/src/cpu/x86/Kconfig
@@ -14,10 +14,6 @@
bool
default n

-config CPU_X86_TSC
- bool
- default n
-
# TODO These two options look too similar
config PARALLEL_CPU_INIT
bool
@@ -53,7 +49,6 @@
config UDELAY_TSC
bool
default n
- select CPU_X86_TSC

config UNKNOWN_TSC_RATE
bool
diff --git a/src/cpu/x86/Makefile.inc b/src/cpu/x86/Makefile.inc
index c661d4a..258a405 100644
--- a/src/cpu/x86/Makefile.inc
+++ b/src/cpu/x86/Makefile.inc
@@ -3,7 +3,7 @@
subdirs-$(CONFIG_CPU_X86_LAPIC) += lapic
subdirs-$(CONFIG_CPU_X86_MTRR) += mtrr
subdirs-$(CONFIG_CPU_X86_SMM) += smm
-subdirs-$(CONFIG_CPU_X86_TSC) += tsc
+subdirs-y += tsc
subdirs-$(CONFIG_PARALLEL_MP) += name
ramstage-$(CONFIG_PARALLEL_MP) += mp_init.c
ramstage-y += backup_default_smm.c
diff --git a/src/soc/amd/stoneyridge/Kconfig b/src/soc/amd/stoneyridge/Kconfig
index 64aec1f..59d2be5 100644
--- a/src/soc/amd/stoneyridge/Kconfig
+++ b/src/soc/amd/stoneyridge/Kconfig
@@ -16,7 +16,6 @@
select CPU_X86_LAPIC
select CPU_X86_MTRR
select CPU_X86_SMM
- select CPU_X86_TSC
select X86_AMD_FIXED_MTRRS
select ACPI_AMD_HARDWARE_SLEEP_VALUES
select COLLECT_TIMESTAMPS_NO_TSC

To view, visit change 44313. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9961228ff0f32bb5ea7fdf4f0dc06adba35b122
Gerrit-Change-Number: 44313
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-MessageType: newchange