View Change
2 comments:
Commit Message:
Patch Set #51, Line 23: 84
In decimal?
Patch Set #51, Line 26:
Please mention, why the code can’t be shared with the x11-lga1151 series code.
It's a different platform (Coffee Lake vs Skylake/Kaby Lake), so sharing code is just not worth the hassle. We don't use variants in coreboot when the boards use different chipset code anyway.
To view, visit change 37441. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ab1cb9462607b9af068bc2374508d99c60d0a30
Gerrit-Change-Number: 37441
Gerrit-PatchSet: 51
Gerrit-Owner: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Guido Beyer @ Prodrive Technologies <guido.beyer@prodrive-technologies.com>
Gerrit-Reviewer: Justin van Son <justin.van.son@prodrive-technologies.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph@9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Reviewer: Stef van Os <stef.van.os@prodrive-technologies.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: wouter.eckhardt@prodrive-technologies.com
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sun, 07 Jun 2020 22:49:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: comment