Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Julius Werner, Kapil Porwal, Rishika Raj, Tarun.
View Change
4 comments:
Commit Message:
Patch Set #1, Line 7: soc/intel/meteorlake: Change DCACHE_BSP_STACK_SIZE
how about a more crisp commit msg
```
soc/intel/meteorlake: Increase CAR STACK_SIZE to meet coreboot requirements
This change increases the DCACHE_BSP_STACK_SIZE from 512KB + 1KB to 512KB + 32KB, addressing a requirement specified by coreboot where stack usage is higher than 1KB alone.
```
Patch Set #1, Line 8:
`Possible unwrapped commit description (prefer a maximum 72 chars per line)`
Please fix.
Patch Set #1, Line 11: Bug
BUG
Patch Set #1, Line 12: Test
TEST
To view, visit change 83540. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iba3620b3b7c470176330f5e07989cd3f6238713e
Gerrit-Change-Number: 83540
Gerrit-PatchSet: 1
Gerrit-Owner: Rishika Raj <rishikaraj@google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot@google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani@google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga@google.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Tarun <tstuli@gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Rishika Raj <rishikaraj@google.com>
Gerrit-Attention: Eran Mitrani <mitrani@google.com>
Gerrit-Attention: Jakub Czapiga <czapiga@google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal@google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot@google.com>
Gerrit-Attention: Julius Werner <jwerner@chromium.org>
Gerrit-Attention: Tarun <tstuli@gmail.com>
Gerrit-Comment-Date: Thu, 18 Jul 2024 08:01:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No