Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/21862 )
Change subject: drivers/net/r8168: Add customized LED mode ......................................................................
Patch Set 1: Code-Review-1
(4 comments)
https://review.coreboot.org/#/c/21862/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/21862/1//COMMIT_MSG@17 PS1, Line 17: RT8111H_CUSOMIZED_LED_VALUE in Kconfig file : under target board Board specific settings should go into devicetree as much as possible.
https://review.coreboot.org/#/c/21862/1/src/drivers/net/r8168.c File src/drivers/net/r8168.c:
https://review.coreboot.org/#/c/21862/1/src/drivers/net/r8168.c@218 PS1, Line 218: #if IS_ENABLED(CONFIG_RT8111H_SET_LED_MODE) if (!IS_ENABLED(...)) return;
https://review.coreboot.org/#/c/21862/1/src/drivers/net/r8168.c@221 PS1, Line 221: /* check the VPD for the mac address */ : setting = CONFIG_RT8111H_CUSTOMIZED_LED_VALUE; this is a Kconfig option, not VPD.
Also if it is mainboard specific it should go into devicetree, not Kconfig.
https://review.coreboot.org/#/c/21862/1/src/drivers/net/r8168.c@228 PS1, Line 228: /* Refer to datasheet 7.2, starting from offset 0x18 add title please