Attention is currently required from: Felix Singer, Lance Zhao, Nico Huber, Johnny Lin, Angel Pons, Arthur Heymans, Michael Niewöhner, Patrick Rudolph.
1 comment:
File util/inteltool/inteltool.c:
Patch Set #18, Line 521: <start-end>
> Technically `<start-end>` already covers the single-core case. Because […]
Ok, I see. Thanks for your comments.
In this case, I would prefer the shorter option:
--cpu-range <start>[-<end>] (this fits perfectly into the current boundaries in
the usage help).
And yes, you are right, we are not immune from the case when the second
parameter is incorrect: 1-qwerty, or even the first - 1qwerty (both cases will
return 1 for us)...
If we want to avoid this, for example, we can calculate the number of characters
for cores_range_start and compare this with the length of the optarg or use
something better than sscanf. But I don't think it needs to be complicated.
To view, visit change 35919. To unsubscribe, or for help writing mail filters, visit settings.