Attention is currently required from: Hung-Te Lin. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56764 )
Change subject: soc/mediatek/mt8195: Add devapc basic drivers ......................................................................
Patch Set 3:
(19 comments)
File src/soc/mediatek/mt8195/devapc.c:
https://review.coreboot.org/c/coreboot/+/56764/comment/b82579c3_f0529c7e PS2, Line 44: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12),
line over 96 characters
Please fix.
https://review.coreboot.org/c/coreboot/+/56764/comment/f55a32bd_8081c577 PS2, Line 51: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12),
line over 96 characters
Please fix.
https://review.coreboot.org/c/coreboot/+/56764/comment/bb4f6b77_a85a4764 PS2, Line 63: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12),
line over 96 characters
Please fix.
https://review.coreboot.org/c/coreboot/+/56764/comment/b86c7fe8_86ac1b08 PS2, Line 67: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12),
line over 96 characters
Please fix.
https://review.coreboot.org/c/coreboot/+/56764/comment/638916de_a1692057 PS2, Line 69: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12),
line over 96 characters
Please fix.
https://review.coreboot.org/c/coreboot/+/56764/comment/ebee2eae_02ae62a4 PS2, Line 88: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12),
line over 96 characters
Please fix.
https://review.coreboot.org/c/coreboot/+/56764/comment/67966899_148930e7 PS2, Line 1282: SEC_RW_ONLY, FORBIDDEN15),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/56764/comment/9744926e_e8ebb465 PS2, Line 1282: SEC_RW_ONLY, FORBIDDEN15),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/56764/comment/0b724a4b_6be780d6 PS2, Line 1282: SEC_RW_ONLY, FORBIDDEN15),
please, no space before tabs
Please fix.
https://review.coreboot.org/c/coreboot/+/56764/comment/3f3931d3_c8591222 PS2, Line 1439: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12),
line over 96 characters
Please fix.
https://review.coreboot.org/c/coreboot/+/56764/comment/067f28c5_2403790f PS2, Line 1477: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12),
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/56764/comment/b3179dd5_007d88a9 PS2, Line 1477: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12),
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/56764/comment/f4fad10b_d32475cd PS2, Line 1477: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12),
please, no space before tabs
Please fix.
https://review.coreboot.org/c/coreboot/+/56764/comment/4f78906d_8355005d PS2, Line 1477: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12),
line over 96 characters
Please fix.
https://review.coreboot.org/c/coreboot/+/56764/comment/e21d5a31_42316a65 PS2, Line 1478: DAPC_PERI2_AO_SYS0_ATTR("EMI_MPU_APB_S",
code indent should use tabs where possible
Please fix.
https://review.coreboot.org/c/coreboot/+/56764/comment/eca43283_ee5048ef PS2, Line 1478: DAPC_PERI2_AO_SYS0_ATTR("EMI_MPU_APB_S",
please, no space before tabs
Please fix.
https://review.coreboot.org/c/coreboot/+/56764/comment/7258da51_acf2ace4 PS2, Line 1478: DAPC_PERI2_AO_SYS0_ATTR("EMI_MPU_APB_S",
please, no spaces at the start of a line
Please fix.
https://review.coreboot.org/c/coreboot/+/56764/comment/e2b0008b_317c09ce PS2, Line 1508: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12),
line over 96 characters
Please fix.
https://review.coreboot.org/c/coreboot/+/56764/comment/904497eb_ccefe661 PS2, Line 1517: NO_PROTECTION, FORBIDDEN, FORBIDDEN, NO_PROTECTION, FORBIDDEN12),
line over 96 characters
Please fix.