Felix Held has uploaded this change for review.
[WIP] vc/amd/opensil/genoa_poc: add TODO
When the device right below the MPIO chip driver has downstream devices
without another chip in between, those downstream devices will also have
their chip_ops entry set to vendorcode_amd_opensil_genoa_poc_mpio_ops
resulting in non-expected behavior. This still needs to be addressed,
but for now add a TODO.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I6ba90fdc83ba089127e6722778bfef29dd480bb4
---
M src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/80149/1
diff --git a/src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c b/src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c
index 28e529d..8174e2e 100644
--- a/src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c
+++ b/src/vendorcode/amd/opensil/genoa_poc/mpio/chip.c
@@ -189,5 +189,7 @@
/* Find all devices with this chip */
for (struct device *dev = &dev_root; dev; dev = dev->next)
if (dev->chip_ops == &vendorcode_amd_opensil_genoa_poc_mpio_ops)
+ /* TODO: add check to only run this for devices right below the MPIO
+ chip and not their child devices */
per_device_config(mpio_data, dev->bus->dev, dev->chip_info);
}
To view, visit change 80149. To unsubscribe, or for help writing mail filters, visit settings.