3 comments:
File src/soc/intel/common/basecode/reset/reset.c:
Patch Set #8, Line 11: do_global_reset
force_global_reset?
I'd rather keep the name as-is, for consistency with `do_full_reset` and `do_system_reset` (cf9_reset.h)
Patch Set #8, Line 22: /* Now BIOS can write 0x06 or 0x0E to 0xCF9 port to global reset platform */
I'd say that's included above, so drop that comment maybe
I might be weird, but I like to have a comment explaining why `do_full_reset` doesn't do a full reset. 😄
Patch Set #8, Line 31: global_reset
Hmmm, shouldn't this be `do_global_reset`?
To view, visit change 45336. To unsubscribe, or for help writing mail filters, visit settings.