4 comments:
File src/soc/intel/apollolake/include/soc/nvs.h:
uint8_t e4gm; /* 0x3D - Enable above 4GB MMIO Resource */
uint64_t a4gb; /* 0x3E - 0x45 Base of above 4GB MMIO Resource */
uint64_t a4gs; /* 0x46 - 0x4D Length of above 4GB MMIO Resource */
Right now they are listed under "Miscellaneous" since these are specific to Intel SoCs, we probably have them in a separate section. OR may be a common NVS structure in intel/common and then SoCs can define any custom variables here.
File src/soc/intel/common/block/systemagent/systemagent.c:
Patch Set #4, Line 19: nclude <device/pci_ops.h>
required?
Patch Set #4, Line 82: gnvs->a4gb
should be gnvs->a4gs?
File src/soc/intel/skylake/include/soc/iomap.h:
Patch Set #4, Line 78: 0x2000000000
nit: 128*GiB here and everywhere would be nice
To view, visit change 38125. To unsubscribe, or for help writing mail filters, visit settings.