Patrick Georgi submitted this change.

View Change

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved
  Michael Niewöhner: Looks good to me, approved

mb/google/reef (and variants): add ACPI backlight support

Enables backlight control under Windows 10.

Test: build/boot Windows 10 20H2 on google/reef, verify
display backlight controls functional.

Change-Id: I4ce613badbdcfb9c843f52408df26c6cbb4b82a2
Signed-off-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49057
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
---
M src/mainboard/google/reef/dsdt.asl
M src/mainboard/google/reef/variants/baseboard/devicetree.cb
M src/mainboard/google/reef/variants/coral/devicetree.cb
M src/mainboard/google/reef/variants/pyro/devicetree.cb
M src/mainboard/google/reef/variants/sand/devicetree.cb
M src/mainboard/google/reef/variants/snappy/devicetree.cb
6 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/src/mainboard/google/reef/dsdt.asl b/src/mainboard/google/reef/dsdt.asl
index f87b962..ecd44f6 100644
--- a/src/mainboard/google/reef/dsdt.asl
+++ b/src/mainboard/google/reef/dsdt.asl
@@ -25,6 +25,7 @@
 			#include <soc/intel/apollolake/acpi/northbridge.asl>
 			#include <soc/intel/apollolake/acpi/southbridge.asl>
 			#include <soc/intel/apollolake/acpi/pch_hda.asl>
+                        #include <drivers/intel/gma/acpi/default_brightness_levels.asl>
 		}
 	}
 
diff --git a/src/mainboard/google/reef/variants/baseboard/devicetree.cb b/src/mainboard/google/reef/variants/baseboard/devicetree.cb
index a1b7a4c..9aadc9e 100644
--- a/src/mainboard/google/reef/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/reef/variants/baseboard/devicetree.cb
@@ -125,7 +125,9 @@
 		device pci 00.0 on  end	# - Host Bridge
 		device pci 00.1 on  end	# - DPTF
 		device pci 00.2 on  end	# - NPK
-		device pci 02.0 on  end	# - Gen
+		device pci 02.0 on	# - Gen
+			register "gfx" = "GMA_DEFAULT_PANEL(0)"
+		end
 		device pci 03.0 on  end	# - Iunit
 		device pci 0d.0 on  end	# - P2SB
 		device pci 0d.1 on  end	# - PMC
diff --git a/src/mainboard/google/reef/variants/coral/devicetree.cb b/src/mainboard/google/reef/variants/coral/devicetree.cb
index 6492931..e8f8cc3 100644
--- a/src/mainboard/google/reef/variants/coral/devicetree.cb
+++ b/src/mainboard/google/reef/variants/coral/devicetree.cb
@@ -125,7 +125,9 @@
 		device pci 00.0 on  end	# - Host Bridge
 		device pci 00.1 on  end	# - DPTF
 		device pci 00.2 on  end	# - NPK
-		device pci 02.0 on  end	# - Gen
+		device pci 02.0 on	# - Gen
+			register "gfx" = "GMA_DEFAULT_PANEL(0)"
+		end
 		device pci 03.0 on  end	# - Iunit
 		device pci 0d.0 on  end	# - P2SB
 		device pci 0d.1 on  end	# - PMC
diff --git a/src/mainboard/google/reef/variants/pyro/devicetree.cb b/src/mainboard/google/reef/variants/pyro/devicetree.cb
index 0dbaa29..af459be 100644
--- a/src/mainboard/google/reef/variants/pyro/devicetree.cb
+++ b/src/mainboard/google/reef/variants/pyro/devicetree.cb
@@ -134,7 +134,9 @@
 		device pci 00.0 on  end	# - Host Bridge
 		device pci 00.1 on  end	# - DPTF
 		device pci 00.2 on  end	# - NPK
-		device pci 02.0 on  end	# - Gen
+		device pci 02.0 on	# - Gen
+			register "gfx" = "GMA_DEFAULT_PANEL(0)"
+		end
 		device pci 03.0 on  end	# - Iunit
 		device pci 0d.0 on  end	# - P2SB
 		device pci 0d.1 on  end	# - PMC
diff --git a/src/mainboard/google/reef/variants/sand/devicetree.cb b/src/mainboard/google/reef/variants/sand/devicetree.cb
index ba19369..91555ad 100644
--- a/src/mainboard/google/reef/variants/sand/devicetree.cb
+++ b/src/mainboard/google/reef/variants/sand/devicetree.cb
@@ -121,7 +121,9 @@
 		device pci 00.0 on  end	# - Host Bridge
 		device pci 00.1 on  end	# - DPTF
 		device pci 00.2 on  end	# - NPK
-		device pci 02.0 on  end	# - Gen
+		device pci 02.0 on	# - Gen
+			register "gfx" = "GMA_DEFAULT_PANEL(0)"
+		end
 		device pci 03.0 on  end	# - Iunit
 		device pci 0d.0 on  end	# - P2SB
 		device pci 0d.1 on  end	# - PMC
diff --git a/src/mainboard/google/reef/variants/snappy/devicetree.cb b/src/mainboard/google/reef/variants/snappy/devicetree.cb
index 3be68dd..d4e9705 100644
--- a/src/mainboard/google/reef/variants/snappy/devicetree.cb
+++ b/src/mainboard/google/reef/variants/snappy/devicetree.cb
@@ -130,7 +130,9 @@
 		device pci 00.0 on  end	# - Host Bridge
 		device pci 00.1 on  end	# - DPTF
 		device pci 00.2 on  end	# - NPK
-		device pci 02.0 on  end	# - Gen
+		device pci 02.0 on	# - Gen
+			register "gfx" = "GMA_DEFAULT_PANEL(0)"
+		end
 		device pci 03.0 on  end	# - Iunit
 		device pci 0d.0 on  end	# - P2SB
 		device pci 0d.1 on  end	# - PMC

To view, visit change 49057. To unsubscribe, or for help writing mail filters, visit settings.