Angel Pons submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Michael Niewöhner: Looks good to me, but someone else must approve
cpu/intel/haswell: Add Broadwell CPUIDs and microcode

Broadwell can now use the Haswell CPU driver.

Change-Id: I36138cab72b1e3ad0ff7f6434996f5ce00de9d0d
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46942
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Michael Niewöhner <foss@mniewoehner.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/cpu/intel/haswell/Makefile.inc
M src/cpu/intel/haswell/haswell_init.c
2 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/src/cpu/intel/haswell/Makefile.inc b/src/cpu/intel/haswell/Makefile.inc
index b93b911..3c4db4f 100644
--- a/src/cpu/intel/haswell/Makefile.inc
+++ b/src/cpu/intel/haswell/Makefile.inc
@@ -23,3 +23,7 @@

cpu_microcode_bins += $(wildcard 3rdparty/intel-microcode/intel-ucode/06-3c-*)
cpu_microcode_bins += $(wildcard 3rdparty/intel-microcode/intel-ucode/06-45-*)
+
+ifeq ($(CONFIG_SOC_INTEL_BROADWELL),y)
+cpu_microcode_bins += 3rdparty/blobs/soc/intel/broadwell/microcode.bin
+endif
diff --git a/src/cpu/intel/haswell/haswell_init.c b/src/cpu/intel/haswell/haswell_init.c
index 04f5802..577061c 100644
--- a/src/cpu/intel/haswell/haswell_init.c
+++ b/src/cpu/intel/haswell/haswell_init.c
@@ -728,6 +728,10 @@
{ X86_VENDOR_INTEL, CPUID_HASWELL_ULT_C0 },
{ X86_VENDOR_INTEL, CPUID_CRYSTALWELL_B0 },
{ X86_VENDOR_INTEL, CPUID_CRYSTALWELL_C0 },
+ { X86_VENDOR_INTEL, CPUID_BROADWELL_C0 },
+ { X86_VENDOR_INTEL, CPUID_BROADWELL_ULT_C0 },
+ { X86_VENDOR_INTEL, CPUID_BROADWELL_ULT_D0 },
+ { X86_VENDOR_INTEL, CPUID_BROADWELL_ULT_E0 },
{ 0, 0 },
};


To view, visit change 46942. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36138cab72b1e3ad0ff7f6434996f5ce00de9d0d
Gerrit-Change-Number: 46942
Gerrit-PatchSet: 17
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged