Attention is currently required from: Nico Huber, Angel Pons, Patrick Rudolph.

7 comments:

File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
- Patch Set #4, Line 27:
```
 * macro: find_free_mtrr
	 * Clobbers %eax, %ebx, %ecx, %edx.
	 * If not found %ebx is 0.
	 * If found MTRR_BASE is at %ecx.
```
  > Note: the MTRR MSRs are contiguous, and alternating between BASE and MASK: […]
  Done
- Patch Set #4, Line 32: .macro find_free_mtrr
  nit: Maybe don't indent this?
  Both seem to be present in the codebase. Looks a bit better if not indented.
- Patch Set #4, Line 43: 2f
  right. Personally, I'd prefer names so that code self-documents
  I'm not sure if that is a good idea in a macro.
- Patch Set #4, Line 123: jne 1f
  Or even jz .halt_forever
  je is the same as jz.
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
- Patch Set #6, Line 26: /*
  The comment looks rather weird now that the macro declaration isn't indented.
  Done
- Patch Set #6, Line 35: put
  out
  Done
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
- Patch Set #7, Line 152:
```
cmp	$0, %ebx
	jne	1f
	jmp	.halt_forever
```
  Simpler: […]
  Done

To view, visit change 37190. To unsubscribe, or for help writing mail filters, visit settings.