View Change
1 comment:
Commit Message:
Patch Set #1, Line 11: some register bits).
Can we mention the functions that additionally have their interrupt pin routed after this change?
Done.
Is there any risk that we could trigger interrupt on hardware that will not have their OS driver loaded? I don't remember what would happen then, that GSI/PIRQ line may end up being disabled completely.
For these functions, it is rather unlikely (PCIe root ports
and disabled/hidden SATA 2). But generally you are right, Linux
would disable the interrupt vector. Also, I have never encountered
Intel-chipset-integrated devices that would trigger interrupts
without being asked to. Buggy payload could forget to disable
them again, though.
To view, visit change 31498. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33f82702ea9c1b9c22ce14f01ee630dbf6203362
Gerrit-Change-Number: 31498
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin@chromium.org>
Gerrit-Comment-Date: Wed, 20 Feb 2019 15:32:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-MessageType: comment