Attention is currently required from: Brandon Breitenstein. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47684 )
Change subject: soc/tigerlake: Update early TCSS code to not call back and forth between mainboard and soc ......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4: I see some comments from earlier patchsets are still not addressed. I will wait for you to go through those and update the CL before reviewing it.
File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/47684/comment/fd7c18e6_2395afd2 PS2, Line 286: system_requires_early_display
Done
I don't think this is addressed in latest patchset?
https://review.coreboot.org/c/coreboot/+/47684/comment/29367e64_c9237b79 PS2, Line 296: __weak
I left a weak here in case it doesn't get implemented and it didn't have a check for display support […]
If mainboard selects the respective Kconfig, it should implement the required callback. If it does not, then the build should fail so that the mainboard developer fixes it.