Patch Set 13:

src/soc/amd/picasso/memlayout_x86.ld will need to be edited as well. I think it can live just before the ASSERTs just below BOOTBLOCK entry.

Hrmm. I just remembered we're statically laying things out so we'll need to double check addresses.

Ehh... Picasso is a whole different can of worms with the whole verstage-before-bootblock thing violating basic assumptions. It doesn't have FMAP_CACHE support yet either, I think? (I saw Martin upload something once but don't remember if it really went through...) I think I wanna focus on getting this to work on the normal boards first, and let the AMD situation fully settle, and then I'll eventually probably have to ask some platform experts for help to see how we can get all this to work on there.

I can fix Asurada for now though.

I can help w/ the right entry in the linker script. Please remind me when you are ready for it.

View Change

To view, visit change 38424. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0abd1c813aece6e78fb883f292ce6c9319545c44
Gerrit-Change-Number: 38424
Gerrit-PatchSet: 14
Gerrit-Owner: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Philipp Hug <philipp@hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich@gmail.com>
Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Fri, 09 Oct 2020 01:27:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment