Attention is currently required from: Robert Zieba, Rob Barnes, Karthik Ramasubramanian, Felix Held.
Hello Robert Zieba, build bot (Jenkins), Raul Rangel, Rob Barnes, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/66573
to look at the new patch set (#6).
Change subject: util/amdfwtool/amdfwread: Fix AMDFW_OPT* bit mask ......................................................................
util/amdfwtool/amdfwread: Fix AMDFW_OPT* bit mask
Optional arguments that involve printing information from the firmware image is mapped to bit fields with bit 31 set. But instead of just setting bit 31, bits 27 - 31 are set. Fix AMDFW_OPT* bit mask.
BUG=None TEST=Build and use amdfwread to read the Soft-fuse bits from Guybrush BIOS image. Observed no changes before and after the changes.
Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Change-Id: I0d88669bace45f3332c5e56527516b2f38295a48 --- M util/amdfwtool/amdfwread.c 1 file changed, 28 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/66573/6