Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86593?usp=email ) Change subject: mb/google/fatcat/var/francka: Adjust NVMe SSD power sequence ...................................................................... mb/google/fatcat/var/francka: Adjust NVMe SSD power sequence Move SSD enable/reset pins to romstage to have more time for initialization. BUG=b:398070426 BRANCH=None TEST=Build francka and do EC reset to check the SSD boots to OS successfully Change-Id: I468ba34a54046ef6ed3d5ec4c625a87bb5255640 Signed-off-by: Frank Wu <frank_wu@compal.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86593 Reviewed-by: Ian Feng <ian_feng@compal.corp-partner.google.com> Reviewed-by: Kapil Porwal <kapilporwal@google.com> Reviewed-by: Dtrain Hsu <dtrain_hsu@compal.corp-partner.google.com> Reviewed-by: Subrata Banik <subratabanik@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> --- M src/mainboard/google/fatcat/variants/francka/gpio.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Kapil Porwal: Looks good to me, approved build bot (Jenkins): Verified Ian Feng: Looks good to me, approved Dtrain Hsu: Looks good to me, approved Subrata Banik: Looks good to me, approved diff --git a/src/mainboard/google/fatcat/variants/francka/gpio.c b/src/mainboard/google/fatcat/variants/francka/gpio.c index 6265b16..f2868fc 100644 --- a/src/mainboard/google/fatcat/variants/francka/gpio.c +++ b/src/mainboard/google/fatcat/variants/francka/gpio.c @@ -416,6 +416,8 @@ /* Pad configuration in romstage */ static const struct pad_config romstage_gpio_table[] = { + /* GPP_B16: SOC_SSD2_EN */ + PAD_CFG_GPO(GPP_B16, 1, PLTRST), /* GPP_C00: SOC_SMBCLK */ PAD_CFG_NF(GPP_C00, NONE, DEEP, NF1), /* GPP_C01: SOC_SMBDATA */ @@ -424,6 +426,8 @@ PAD_CFG_GPO(GPP_H03, 0, DEEP), /* GPP_H17: FP_RST_1V8_OD# */ PAD_CFG_GPO(GPP_H17, 0, DEEP), + /* GPP_E03: SOC_SSD2_RST# */ + PAD_CFG_GPO(GPP_E03, 1, PLTRST), }; const struct pad_config *variant_gpio_table(size_t *num) -- To view, visit https://review.coreboot.org/c/coreboot/+/86593?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I468ba34a54046ef6ed3d5ec4c625a87bb5255640 Gerrit-Change-Number: 86593 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Wu <frank_wu@compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu@compal.corp-partner.google.com> Gerrit-Reviewer: Ian Feng <ian_feng@compal.corp-partner.google.com> Gerrit-Reviewer: Jayvik Desai <jayvik@google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com> Gerrit-Reviewer: Pranava Y N <pranavayn@google.com> Gerrit-Reviewer: Subrata Banik <subratabanik@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang@compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>