Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45472 ) Change subject: cpu/x86/smm: Add save state ops for different save states ...................................................................... Patch Set 2: (1 comment) https://review.coreboot.org/c/coreboot/+/45472/1/src/cpu/amd/smm/amd64_save_... File src/cpu/amd/smm/amd64_save_state.c: https://review.coreboot.org/c/coreboot/+/45472/1/src/cpu/amd/smm/amd64_save_... PS1, Line 96: pm_acpi_smi_cmd_port needs to be in a header somewhere. -- To view, visit https://review.coreboot.org/c/coreboot/+/45472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I67ab44fbdca5fac5837d32ffda5caad61e534473 Gerrit-Change-Number: 45472 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 27 Sep 2020 10:38:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment