Patch Set 2:
> why don't you include <console.h> here "src/device/oprom/x86emu/debug.h"
instead of src/device/oprom/include/x86emu/x86emu.h ?

I've put it where it's been before. Should I change it?

(git log -p src/device/oprom/x86emu/debug.h)

<console.h> is missing here: src/device/oprom/x86emu/debug.h
so I would add that include into "src/device/oprom/x86emu/debug.h" and not src/device/oprom/include/x86emu/x86emu.h

View Change

To view, visit change 32499. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I75d0b7c08bfa6dcb07778bbb762223b62cfc3da7
Gerrit-Change-Number: 32499
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Kepplinger <martink@posteo.de>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Martin Kepplinger <martink@posteo.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh@siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Mon, 29 Apr 2019 10:43:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment