29 comments:
Since it's not trivial to me, could you mention how the code is "refactored" (by moving between files)? For example, why the code mt8173 and mt8183 needs to be changed?
File src/soc/mediatek/common/rtc.c:
Does 0 mean success or failure here?
File src/soc/mediatek/common/rtc_osc_init.c:
Patch Set #51, Line 4: #include <soc/rtc.h>
rtc.h should come before rtc_common.h
Patch Set #51, Line 9: diff1, diff2
diff_left, diff_right
No need to initialize this and "middle".
%#x
Remove extra blank line.
if (val > RTC_FQMTR_LOW_BASE)
diff1 = val - RTC_FQMTR_LOW_BASE;
else
diff1 = RTC_FQMTR_LOW_BASE - val;
This can be simplified to
diff1 = ABS(val - RTC_FQMTR_LOW_BASE)
Same for diff2.
One space after ":"
Please be consistent with the case (C or c).
File src/soc/mediatek/mt8173/include/soc/rtc.h:
failed
failed
File src/soc/mediatek/mt8173/rtc.c:
w
No period for consistency with comments above.
I
File src/soc/mediatek/mt8183/include/soc/rtc.h:
failed
failed
File src/soc/mediatek/mt8183/rtc.c:
Patch Set #51, Line 228: /* in recovery mode, We need 20ms delay for register setting. */
Same.
File src/soc/mediatek/mt8192/include/soc/rtc.h:
Could you add a "," for all the enums in this file?
Patch Set #51, Line 89: to low
low
Patch Set #51, Line 89: lower leakage current hw design change
What does that mean?
File src/soc/mediatek/mt8192/rtc.c:
Patch Set #51, Line 21: (unsigned int)
Do we need the cast? Same below.
Even if we do, the type should be u32.
Patch Set #51, Line 46: /* Unlock for reload */
Move to its own line.
%#x
Patch Set #51, Line 136: out !!
out!
If this is boolean, please use native type such as int.
w
I
%#x
Same for all occurrences in this file.
To view, visit change 46395. To unsubscribe, or for help writing mail filters, visit settings.