12 comments:
Patch Set #12, Line 7: mediatek/mt8183: Use calibration result do fast calibration
*to* looks wrong: […]
Done
. If
Done
for
Done
Patch Set #12, Line 10: use this calibration result do fast calibration to reduce the bootup time.
Some words fit on the line above (75 characters).
Done
Please explain the implementation. What is the shuffling about? […]
Done
File src/soc/mediatek/mt8183/dramc_init_setting.c:
Patch Set #12, Line 616: dramc_dbg("bypass duty calibration\n");
… and use cached calibration data
no need add here
Why u8? Why not `int` or `unsigned int`?
why int better than u8?
Patch Set #12, Line 620: dramc_duty_set_dqs_delay(chn, params->duty_dqs_delay[chn]);
Please measure the times by using the stopwatch framework. (Maybe a separate commit. […]
Done
Patch Set #12, Line 658: die("Invalid DDR frequency group %u\n", freq_group);
Wrong indentation
Done
File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
Patch Set #12, Line 911: dramc_dbg("[bypass Gating]\n");
Why format it like that?
what is the meaning?
Patch Set #12, Line 1759: dramc_dbg("bypass RX vref:%d\n", vref_begin);
Please add a space after the colon.
Done
Patch Set #12, Line 1763: dramc_dbg("bypass TX vref:%d\n", vref_begin);
Ditto.
Done
To view, visit change 35164. To unsubscribe, or for help writing mail filters, visit settings.