Felix Held submitted this change.

View Change

Approvals: Sumeet R Pawnikar: Looks good to me, but someone else must approve Eran Mitrani: Looks good to me, approved Derek Huang: Looks good to me, approved Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified
mb/google/rex/variants/deku: update USB-C port configuration

This CL update setting according to schematic v0.4.

BUG=b:320201111
BRANCH=firmware-rex-15709.B
TEST=Built FW image correctly.

Change-Id: Ia4570d26ee9fd175ed9099bd057cee3c30c95704
Signed-off-by: Tony Huang <tony-huang@quanta.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80156
Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Reviewed-by: Subrata Banik <subratabanik@google.com>
Reviewed-by: Eran Mitrani <mitrani@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Derek Huang <derekhuang@google.com>
---
M src/mainboard/google/rex/variants/deku/overridetree.cb
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/mainboard/google/rex/variants/deku/overridetree.cb b/src/mainboard/google/rex/variants/deku/overridetree.cb
index 9c35338..711d3b6 100644
--- a/src/mainboard/google/rex/variants/deku/overridetree.cb
+++ b/src/mainboard/google/rex/variants/deku/overridetree.cb
@@ -117,21 +117,21 @@
register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
register "use_custom_pld" = "true"
register "custom_pld" = "ACPI_PLD_TYPE_C(BACK, RIGHT, ACPI_PLD_GROUP(2, 1))"
- device ref tcss_usb3_port1 on end
+ device ref tcss_usb3_port2 on end
end
chip drivers/usb/acpi
register "desc" = ""USB3 Type-C Port C2""
register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
register "use_custom_pld" = "true"
register "custom_pld" = "ACPI_PLD_TYPE_C(BACK, CENTER, ACPI_PLD_GROUP(3, 1))"
- device ref tcss_usb3_port2 on end
+ device ref tcss_usb3_port1 on end
end
chip drivers/usb/acpi
register "desc" = ""USB3 Type-C Port C3""
register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
register "use_custom_pld" = "true"
register "custom_pld" = "ACPI_PLD_TYPE_C(FRONT, LEFT, ACPI_PLD_GROUP(4, 1))"
- device ref tcss_usb3_port2 on end
+ device ref tcss_usb3_port3 on end
end
end
end
@@ -156,7 +156,7 @@
end
chip drivers/intel/usb4/retimer
register "dfp[1].power_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_B22)"
- use tcss_usb3_port3 as dfp[0].typec_port
+ use tcss_usb3_port3 as dfp[1].typec_port
device generic 0 on end
end
end
@@ -298,7 +298,7 @@
chip drivers/intel/pmc_mux/conn
#USB2_C3
use usb2_port5 as usb2_port
- use tcss_usb3_port1 as usb3_port
+ use tcss_usb3_port3 as usb3_port
device generic 3 alias conn3 on end
end
end

To view, visit change 80156. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia4570d26ee9fd175ed9099bd057cee3c30c95704
Gerrit-Change-Number: 80156
Gerrit-PatchSet: 2
Gerrit-Owner: Tony Huang <tony-huang@quanta.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang@google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot@google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani@google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Jakub Czapiga <czapiga@google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Kevin Chiu <kevin.chiu@quanta.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Gerrit-Reviewer: Tarun <tstuli@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged