build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48073 )
Change subject: soc/mediatek/mt8192: add dramc power control ......................................................................
Patch Set 2:
(14 comments)
https://review.coreboot.org/c/coreboot/+/48073/2/src/soc/mediatek/mt8192/dra... File src/soc/mediatek/mt8192/dramc_power.c:
https://review.coreboot.org/c/coreboot/+/48073/2/src/soc/mediatek/mt8192/dra... PS2, Line 28: u32 get_vdd1_value() Bad function definition - u32 get_vdd1_value() should probably be u32 get_vdd1_value(void)
https://review.coreboot.org/c/coreboot/+/48073/2/src/soc/mediatek/mt8192/dra... PS2, Line 33: u32 get_vdd2_value() Bad function definition - u32 get_vdd2_value() should probably be u32 get_vdd2_value(void)
https://review.coreboot.org/c/coreboot/+/48073/2/src/soc/mediatek/mt8192/dra... PS2, Line 38: u32 get_vddq_value() Bad function definition - u32 get_vddq_value() should probably be u32 get_vddq_value(void)
https://review.coreboot.org/c/coreboot/+/48073/2/src/soc/mediatek/mt8192/dra... PS2, Line 43: u32 get_vmddr_value() Bad function definition - u32 get_vmddr_value() should probably be u32 get_vmddr_value(void)
https://review.coreboot.org/c/coreboot/+/48073/2/src/soc/mediatek/mt8192/dra... PS2, Line 56: void dramc_set_vdd1_voltage() Bad function definition - void dramc_set_vdd1_voltage() should probably be void dramc_set_vdd1_voltage(void)
https://review.coreboot.org/c/coreboot/+/48073/2/src/soc/mediatek/mt8192/dra... PS2, Line 64: void dramc_set_vdd2_voltage() Bad function definition - void dramc_set_vdd2_voltage() should probably be void dramc_set_vdd2_voltage(void)
https://review.coreboot.org/c/coreboot/+/48073/2/src/soc/mediatek/mt8192/dra... PS2, Line 72: void dramc_set_vddq_voltage() Bad function definition - void dramc_set_vddq_voltage() should probably be void dramc_set_vddq_voltage(void)
https://review.coreboot.org/c/coreboot/+/48073/2/src/soc/mediatek/mt8192/dra... PS2, Line 80: void dramc_set_vmddr_voltage() Bad function definition - void dramc_set_vmddr_voltage() should probably be void dramc_set_vmddr_voltage(void)
https://review.coreboot.org/c/coreboot/+/48073/2/src/soc/mediatek/mt8192/dra... PS2, Line 88: u32 dramc_get_vcore_voltage() Bad function definition - u32 dramc_get_vcore_voltage() should probably be u32 dramc_get_vcore_voltage(void)
https://review.coreboot.org/c/coreboot/+/48073/2/src/soc/mediatek/mt8192/dra... PS2, Line 94: u32 dramc_get_vdd1_voltage() Bad function definition - u32 dramc_get_vdd1_voltage() should probably be u32 dramc_get_vdd1_voltage(void)
https://review.coreboot.org/c/coreboot/+/48073/2/src/soc/mediatek/mt8192/dra... PS2, Line 99: u32 dramc_get_vdd2_voltage() Bad function definition - u32 dramc_get_vdd2_voltage() should probably be u32 dramc_get_vdd2_voltage(void)
https://review.coreboot.org/c/coreboot/+/48073/2/src/soc/mediatek/mt8192/dra... PS2, Line 104: u32 dramc_get_vddq_voltage() Bad function definition - u32 dramc_get_vddq_voltage() should probably be u32 dramc_get_vddq_voltage(void)
https://review.coreboot.org/c/coreboot/+/48073/2/src/soc/mediatek/mt8192/dra... PS2, Line 109: u32 dramc_get_vmddr_voltage() Bad function definition - u32 dramc_get_vmddr_voltage() should probably be u32 dramc_get_vmddr_voltage(void)
https://review.coreboot.org/c/coreboot/+/48073/2/src/soc/mediatek/mt8192/dra... PS2, Line 125: void dramc_dump_voltage() Bad function definition - void dramc_dump_voltage() should probably be void dramc_dump_voltage(void)