3 comments:
File src/soc/mediatek/mt8183/dramc_init_setting.c:
if (have_calibration_params(params)) {
dramc_dbg("bypass duty calibration\n");
for (u8 chn = 0; chn < CHANNEL_MAX; chn++) {
dramc_duty_set_clk_delay(chn, params->duty_clk_delay[chn]);
dramc_duty_set_dqs_delay(chn, params->duty_dqs_delay[chn]);
}
what about just 'return' after done so we don't need the 'else' block to change following lines?
File src/soc/mediatek/mt8183/emi.c:
Patch Set #29, Line 365: const struct sdram_params *freq_params
since dramc_params is already merged in previous change, will it be easier if we pass dramc_params here?
File src/soc/mediatek/mt8183/include/soc/emi.h:
Patch Set #29, Line 88: have_calibration_params
do you want to move this into dramc_params? we can check status, flags, ... everything there
To view, visit change 35164. To unsubscribe, or for help writing mail filters, visit settings.