View Change

11 comments:

• File src/mainboard/supermicro/x9scl/devicetree.cb:

  • Patch Set #2, Line 2: 0x0

    0

  • Patch Set #2, Line 11: end

    You should "pick up" these lone `end` (put them on the previous line)

  • Patch Set #2, Line 16: 0x0

    0

  • Patch Set #2, Line 19: end

    Same here, but also make sure the various `end` are aligned. It just takes an extra space after any `on`:

     device pci 00.0 on  end # Host bridge
     device pci 01.0 on  end # PEG
     device pci 01.1 on  end # PEG
     device pci 06.0 on  end # PEG
     device pci 02.0 off end # iGPU

  • Patch Set #2, Line 30: register "docking_supported" = "0"

    Can be dropped

  • Patch Set #2, Line 35: register "pcie_hotplug_map" = "{ 0, 0, 0, 0, 0, 0, 0, 0 }"

    Can be dropped

  • Patch Set #2, Line 41: off

    Why is this device off?

• File src/mainboard/supermicro/x9scl/dsdt.asl:

  • Patch Set #2, Line 33:

    Scope (\_SB)
    	{
    		Device (PCI0)
    

    You can collapse this:

     Device (\_SB.PCI0)

• File src/mainboard/supermicro/x9scl/early_init.c:

  • Patch Set #2, Line 45: /* 0:1d.0? */

    As written on the devicetree comments, EHCI 1 is 1d.0 and EHCI2 is 1a.0

  • Patch Set #2, Line 63: static const u16 superio_initvals[] = {

    Why, just why?

• File src/mainboard/supermicro/x9scl/superio.h:

  • Patch Set #2:

    I'm pretty sure you can use things in src/superio/ instead.

To view, visit change 38346. To unsubscribe, or for help writing mail filters, visit settings.