[coreboot-gerrit] [S] Change in coreboot[main]: soc/intel/pantherlake: Simplify Panther Lake's pre-cpu time

[Bora Guvendik (Code Review)]

Attention is currently required from: Elyes Haouas, Kapil Porwal, Pranava Y N, Subrata Banik, Wonkyu Kim.

Bora Guvendik has posted comments on this change by Bora Guvendik. ( https://review.coreboot.org/c/coreboot/+/84872?usp=email )

Change subject: soc/intel/pantherlake: Simplify Panther Lake's pre-cpu time
......................................................................

Patch Set 6:

(2 comments)

File src/mainboard/google/fatcat/Kconfig:

https://review.coreboot.org/c/coreboot/+/84872/comment/1970132f_0531be05?usp... :
PS6, Line 34: SOC_INTEL_CSE_PRE_CPU_RESET_TELEMETRY
> isn't this already selected through  […]

With this change, I am not selecting cse_telemetry_v1.h or cse_telemetry_v2.h for PTL (since v1 or v2 doesn't match PTL definitions). So PERF_DATA_CSME_GET_PERF_RESPONSE is not defined.

File src/soc/intel/pantherlake/cse_telemetry.c:

https://review.coreboot.org/c/coreboot/+/84872/comment/3260846a_e74f87ee?usp... :
PS6, Line 9: #define PERF_DATA_CSME_GET_PERF_RESPONSE 63
> I'm confused. […]

no its not, explained in previous comment.