2 comments:
File src/soc/amd/common/block/include/amdblocks/gpio.h:
size_t soc_gpio_event_table_size(void);
int soc_override_event(uint8_t gpio, uint8_t mux, uint8_t *event);
It would be helpful to add comments indicating:
1. That these functions are expected to be implemented by the SoC.
2. What the function is supposed to do.
File src/soc/amd/stoneyridge/gpio.c:
Patch Set #3, Line 49: soc_gpio_event_table_size
Can this be instead renamed to soc_gpio_get_event_table_details which can fill in pointer to event table as well as the size and return back to common code? gpio_event_table[] then wouldn't have to be exposed directly outside the scope of this file.
To view, visit change 32651. To unsubscribe, or for help writing mail filters, visit settings.