I think this revert would be a mistake. The purpose of the testbios utility was to get something in userspace that is comparable to what coreboot does.

The old utility was a complete (or rather, incomplete) implementation based on copy and pasted cr*p from various projects in the field. It would not work on anything but x86, too.

I would much rather see that not go back into the tree, especially in a time when vgabios is virtually dead anyways (What system do you have that this is actually useful to you?)

Patch set 1:Code-Review -1

View Change

To view, visit change 42238. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba4088c1c68c7cab86300d0e786d1ce473ff094f
Gerrit-Change-Number: 42238
Gerrit-PatchSet: 1
Gerrit-Owner: ron minnich <rminnich@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 11 Jun 2020 18:03:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment