View Change
1 comment:
File Makefile.inc:
Patch Set #15, Line 1162: # Ignore segments for .car.data or .earlyram.data while adding romstage.
I don't see anything asserting empty .data. […]
In arch/x86/car.ld we had .illegal globals for all .data.* and additionally the definition of ENV_STAGE_HAS_DATA_SECTION asserted empty .data with ENV_CACHE_AS_RAM. But I was really commenting on (.car and .earlyram).data references we saw here.
The first, .car.data, has always(?) been declared with (NOLOAD) and even after reading CB:7305 commit message I do not see the need to exclude it on the commandline. But elf_to_stage in cbfs-mkstage.c also evolved a lot since that commit, with separation to XIP and non-XIP loading so I have not tried to find a failure case either.
This change seemed equally unnecessary for .earlyram.data so I thought you would have had the answer why it is needed, but I see it now got removed for patchset 20 at least.
To view, visit change 35035. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c084ff6fdcf7e9154436f038705e8679daea780
Gerrit-Change-Number: 35035
Gerrit-PatchSet: 20
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Justin Frodsham <justin.frodsham@protonmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Matt Papageorge <matthewpapa07@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot@felixheld.de>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Wed, 08 Apr 2020 04:34:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson <marshalldawson3rd@gmail.com>
Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki@gmail.com>
Comment-In-Reply-To: Felix Held <felix-coreboot@felixheld.de>
Gerrit-MessageType: comment